mesa.git
13 years agoir_constant_expression: Extract dot product calculation for reuse.
Kenneth Graunke [Thu, 22 Jul 2010 03:09:21 +0000 (20:09 -0700)]
ir_constant_expression: Extract dot product calculation for reuse.

13 years agoir_constant_expression: Remove support for dot products of integers.
Kenneth Graunke [Thu, 22 Jul 2010 01:18:16 +0000 (18:18 -0700)]
ir_constant_expression: Remove support for dot products of integers.

This shouldn't be required since dot is only defined for floating point
types, even in GLSL 4.0.

13 years agoir_constant_expression: Add support for the "greaterThanEqual" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 01:08:05 +0000 (18:08 -0700)]
ir_constant_expression: Add support for the "greaterThanEqual" builtin.

13 years agoir_constant_expression: Add support for the "greaterThan" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 01:07:43 +0000 (18:07 -0700)]
ir_constant_expression: Add support for the "greaterThan" builtin.

13 years agoir_constant_expression: Add support for the "lessThanEqual" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 01:07:09 +0000 (18:07 -0700)]
ir_constant_expression: Add support for the "lessThanEqual" builtin.

13 years agoir_constant_expression: Add support for the "lessThan" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 01:06:18 +0000 (18:06 -0700)]
ir_constant_expression: Add support for the "lessThan" builtin.

13 years agoir_constant_expression: Add support for the "notEqual" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 01:05:36 +0000 (18:05 -0700)]
ir_constant_expression: Add support for the "notEqual" builtin.

13 years agoir_constant_expression: Add support for the "equal" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 01:04:22 +0000 (18:04 -0700)]
ir_constant_expression: Add support for the "equal" builtin.

13 years agoir_constant_expression: Add support for the "distance" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 01:01:22 +0000 (18:01 -0700)]
ir_constant_expression: Add support for the "distance" builtin.

13 years agoir_constant_expression: Add support for the "degrees" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:59:00 +0000 (17:59 -0700)]
ir_constant_expression: Add support for the "degrees" builtin.

13 years agoir_constant_expression: Add support for the "radians" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:58:03 +0000 (17:58 -0700)]
ir_constant_expression: Add support for the "radians" builtin.

13 years agoir_constant_expression: Add support for the "tanh" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:51:23 +0000 (17:51 -0700)]
ir_constant_expression: Add support for the "tanh" builtin.

13 years agoir_constant_expression: Add support for the "tan" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:50:50 +0000 (17:50 -0700)]
ir_constant_expression: Add support for the "tan" builtin.

13 years agoir_constant_expression: Add support for the "sinh" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:49:56 +0000 (17:49 -0700)]
ir_constant_expression: Add support for the "sinh" builtin.

13 years agoir_constant_expression: Add support for the "cosh" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:47:55 +0000 (17:47 -0700)]
ir_constant_expression: Add support for the "cosh" builtin.

13 years agoir_constant_expression: Add support for "atan" builtins.
Kenneth Graunke [Thu, 22 Jul 2010 00:42:23 +0000 (17:42 -0700)]
ir_constant_expression: Add support for "atan" builtins.

13 years agoir_constant_expression: Add support for "acos" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:39:47 +0000 (17:39 -0700)]
ir_constant_expression: Add support for "acos" builtin.

13 years agoir_constant_expression: Add support for "asin" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:38:38 +0000 (17:38 -0700)]
ir_constant_expression: Add support for "asin" builtin.

13 years agoir_constant_expression: Add support for "any" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:35:52 +0000 (17:35 -0700)]
ir_constant_expression: Add support for "any" builtin.

13 years agoir_constant_expression: Add support for "all" builtin.
Kenneth Graunke [Thu, 22 Jul 2010 00:34:32 +0000 (17:34 -0700)]
ir_constant_expression: Add support for "all" builtin.

13 years agoir_constant_expression: Implement builtins that wrap an expression.
Kenneth Graunke [Wed, 21 Jul 2010 23:57:53 +0000 (16:57 -0700)]
ir_constant_expression: Implement builtins that wrap an expression.

These builtin functions are represented by ir_expression_operations, so
we can just create one of those and ask for its value.

13 years agoir_constant_expression: Add support for builtins dFdx, dFdy, and fwidth.
Kenneth Graunke [Wed, 21 Jul 2010 23:57:10 +0000 (16:57 -0700)]
ir_constant_expression: Add support for builtins dFdx, dFdy, and fwidth.

These always return zero (the derivative of a constant).

13 years agoast_function: Set constant_value on return value temporaries in 1.20+.
Kenneth Graunke [Fri, 23 Jul 2010 01:29:29 +0000 (18:29 -0700)]
ast_function: Set constant_value on return value temporaries in 1.20+.

13 years agoir_constant_expression: Stub out support for constant builtins.
Kenneth Graunke [Wed, 21 Jul 2010 23:55:46 +0000 (16:55 -0700)]
ir_constant_expression: Stub out support for constant builtins.

13 years agoir_constant_expression: Use Mesa's MIN2/MAX2 instead of our own.
Kenneth Graunke [Thu, 22 Jul 2010 04:56:13 +0000 (21:56 -0700)]
ir_constant_expression: Use Mesa's MIN2/MAX2 instead of our own.

13 years agoir_algebraic: Use ir_constant::zero.
Kenneth Graunke [Wed, 28 Jul 2010 19:20:38 +0000 (12:20 -0700)]
ir_algebraic: Use ir_constant::zero.

13 years agoglsl2: Add new ir_constant::zero static method.
Kenneth Graunke [Wed, 21 Jul 2010 22:54:15 +0000 (15:54 -0700)]
glsl2: Add new ir_constant::zero static method.

This conveniently creates a zero value of whatever type you want.

13 years agoglsl2: Add the define for ARB_fragment_coord_conventions when present.
Eric Anholt [Wed, 28 Jul 2010 21:58:31 +0000 (14:58 -0700)]
glsl2: Add the define for ARB_fragment_coord_conventions when present.

Fixes:
glsl-arb-fragment-coord-conventions-define

13 years agoglsl2: Add support for redeclaring layout of gl_FragCoord for ARB_fcc.
Eric Anholt [Wed, 28 Jul 2010 21:41:51 +0000 (14:41 -0700)]
glsl2: Add support for redeclaring layout of gl_FragCoord for ARB_fcc.

Fixes:
glsl-arb-fragment-coord-conventions

13 years agoglsl2: Perform some semantic checking of ARB_fcc layout qualifiers
Ian Romanick [Thu, 1 Jul 2010 00:48:09 +0000 (17:48 -0700)]
glsl2: Perform some semantic checking of ARB_fcc layout qualifiers

The rest cannot be handled until built-in variables (i.e.,
gl_FragCoord) can be redeclared to add qualifiers.

13 years agoglsl2: Parser support for GL_ARB_fragment_coord_conventions
Ian Romanick [Thu, 1 Jul 2010 00:30:03 +0000 (17:30 -0700)]
glsl2: Parser support for GL_ARB_fragment_coord_conventions

13 years agoglsl2: Fail linking where the FS reads a varying that the VS doesn't write.
Eric Anholt [Wed, 28 Jul 2010 20:52:23 +0000 (13:52 -0700)]
glsl2: Fail linking where the FS reads a varying that the VS doesn't write.

Fixes:
glsl1-varying read but not written
glsl1-varying var mismatch

13 years agoglsl2: Unmark unwritten varyings as varying.
Eric Anholt [Wed, 28 Jul 2010 20:42:36 +0000 (13:42 -0700)]
glsl2: Unmark unwritten varyings as varying.

This fixes an assertion failure in ir_to_mesa, and the varying won't
take up varying space.

13 years agoglcpp: Add generated source files.
Carl Worth [Wed, 28 Jul 2010 19:33:56 +0000 (12:33 -0700)]
glcpp: Add generated source files.

This is now consistent with other usage of flex/bison througout mesa,
(which is that these generated files are added to source control so
that the build system does not require external tools like flex/bison
for non-developers).

13 years agoglsl: Ignore glsl_compiler and glsl_parser.output files.
Carl Worth [Wed, 28 Jul 2010 19:30:07 +0000 (12:30 -0700)]
glsl: Ignore glsl_compiler and glsl_parser.output files.

These are generated files where we can do the sane thing, and keep
them out of version control.

13 years agoglsl: Add generated files from flex/bison.
Carl Worth [Wed, 28 Jul 2010 19:27:33 +0000 (12:27 -0700)]
glsl: Add generated files from flex/bison.

The mesa build environment does not (currently) accept external
dependencies such as flex and bison. The compromise is to commit the
generated output files, (in spite of the pain that comes from having
generated files under version control).

13 years agoglcpp: Add expected output for a recently-added test.
Carl Worth [Wed, 28 Jul 2010 19:19:44 +0000 (12:19 -0700)]
glcpp: Add expected output for a recently-added test.

I simply forgot to add this file when adding the test case originally.

13 years agoir_to_mesa: Add remaining state variable (builtin uniforms) support.
Eric Anholt [Wed, 28 Jul 2010 15:13:53 +0000 (08:13 -0700)]
ir_to_mesa: Add remaining state variable (builtin uniforms) support.

Fixes:
glsl1-GL state variable reference (diffuse product)
glsl1-GL state variable reference (gl_FrontMaterial.ambient)
glsl1-GL state variable reference (gl_LightSource[0].diffuse)
glsl1-GL state variable reference (point attenuation)
glsl1-GL state variable reference (point size)
glsl1-linear fog

13 years agoglsl2: Add the remaining builtin uniforms.
Eric Anholt [Wed, 28 Jul 2010 19:23:51 +0000 (12:23 -0700)]
glsl2: Add the remaining builtin uniforms.

13 years agoglsl2: Size builtin arrays according to the context constants.
Eric Anholt [Wed, 28 Jul 2010 15:18:59 +0000 (08:18 -0700)]
glsl2: Size builtin arrays according to the context constants.

Cleans up some of the FINISHMEs in this file.

13 years agoglcpp: Explicitly expect 0 shift/reduce conflicts.
Carl Worth [Wed, 28 Jul 2010 18:10:52 +0000 (11:10 -0700)]
glcpp: Explicitly expect 0 shift/reduce conflicts.

The "%expect 0" construct will make bison emit an error if any future
changes to the grammar introduce shift/reduce conflicts, (without also
increasing the number after "%expect").

13 years agoglcpp: Remove 2 shift/reduce conflicts from the grammar.
Carl Worth [Wed, 28 Jul 2010 18:07:46 +0000 (11:07 -0700)]
glcpp: Remove 2 shift/reduce conflicts from the grammar.

Since we have productions to turn "defined FOO" and "defined ( FOO )"
into a conditional_token we don't need to list DEFINED as an operator
as well. Doing so just introduces the shift/reduce ambiguity with no
benefit.

13 years agoglsl2: When stealing var->constant_value, steal its children as well.
Eric Anholt [Tue, 27 Jul 2010 22:25:07 +0000 (15:25 -0700)]
glsl2: When stealing var->constant_value, steal its children as well.

Fixes:
glsl1-GLSL 1.20 uniform array constructor

13 years agoir_to_mesa: Provide a restricted type size to _mesa_add_uniform.
Eric Anholt [Tue, 27 Jul 2010 22:10:38 +0000 (15:10 -0700)]
ir_to_mesa: Provide a restricted type size to _mesa_add_uniform.

Fixes:
glsl-uniform-out-of-bounds.

13 years agoglsl2: Actually use the linked dead code eliminator.
Eric Anholt [Tue, 27 Jul 2010 21:32:21 +0000 (14:32 -0700)]
glsl2: Actually use the linked dead code eliminator.

I managed to revert the change from unlinked at some point while
cleaning up the changes.  glsl-fs-raytrace-bug27060 drops from 389
instructions to 370.

13 years agoglsl2: Don't dereference a NULL var in CE handling during a compile error.
Eric Anholt [Tue, 27 Jul 2010 19:10:50 +0000 (12:10 -0700)]
glsl2: Don't dereference a NULL var in CE handling during a compile error.

If an undeclared variable was dereferenced in an expression that
needed constant expression handling, we would walk off a null ir->var
pointer.

Fixes:
glsl1-TIntermediate::addUnaryMath

13 years agoir_to_mesa: Add support for array constants.
Eric Anholt [Tue, 27 Jul 2010 18:58:32 +0000 (11:58 -0700)]
ir_to_mesa: Add support for array constants.

Fixes:
glsl1-GLSL 1.20 array constructor 1
glsl1-GLSL 1.20 array constructor 2
glsl1-GLSL 1.20 array.length()
glsl1-GLSL 1.20 const array constructor 1
glsl1-GLSL 1.20 const array constructor 2

13 years agoglsl2: Use ir_dead_code's linked version after linking.
Eric Anholt [Tue, 27 Jul 2010 18:31:12 +0000 (11:31 -0700)]
glsl2: Use ir_dead_code's linked version after linking.

glsl-fs-raytrace-bug27060 goes from 485 Mesa IR instructions to 389
before Mesa IR optimization.

13 years agoglsl2: Fix the linked version of ir_dead_code.
Eric Anholt [Tue, 27 Jul 2010 18:29:17 +0000 (11:29 -0700)]
glsl2: Fix the linked version of ir_dead_code.

If we don't walk into functions, we won't see any usage of variables
in the functions.

13 years agoglsl2: Make the dead code handler make its own talloc context.
Eric Anholt [Tue, 27 Jul 2010 18:28:26 +0000 (11:28 -0700)]
glsl2: Make the dead code handler make its own talloc context.

This way, we don't need to pass in a parse state, and the context
doesn't grow with the number of passes through optimization.

13 years agomesa: Allow large temporary indices coming into the temporary reg allocator.
Eric Anholt [Tue, 27 Jul 2010 18:45:27 +0000 (11:45 -0700)]
mesa: Allow large temporary indices coming into the temporary reg allocator.

This gets glsl-vs-raytrace, glsl-fs-raytrace running on the new
compiler.

13 years agoglsl2: Talloc type names.
Eric Anholt [Tue, 27 Jul 2010 18:14:59 +0000 (11:14 -0700)]
glsl2: Talloc type names.

Otherwise, we end up losing structure names after compile time, and
dumping IR often ends up reporting some other mysterious string.

13 years agoir_to_mesa: Set the swizzle on constant struct src regs.
Eric Anholt [Tue, 27 Jul 2010 17:39:40 +0000 (10:39 -0700)]
ir_to_mesa: Set the swizzle on constant struct src regs.

MESA_GLSL=nopt now produces believable output for glsl-fs-raytrace.

13 years agoir_to_mesa: Fix stray "break" that broke functions of >1 argument.
Eric Anholt [Tue, 27 Jul 2010 17:08:38 +0000 (10:08 -0700)]
ir_to_mesa: Fix stray "break" that broke functions of >1 argument.

13 years agoglsl2: Add optimization pass for algebraic simplifications.
Eric Anholt [Tue, 27 Jul 2010 05:50:29 +0000 (22:50 -0700)]
glsl2: Add optimization pass for algebraic simplifications.

This cleans up the assembly output of almost all the non-logic tests
glsl-algebraic-*.  glsl-algebraic-pow-two needs love (basically,
flattening to a temporary and squaring it).

13 years agoir_validate: Check the types of expression operations.
Eric Anholt [Tue, 27 Jul 2010 16:01:30 +0000 (09:01 -0700)]
ir_validate: Check the types of expression operations.

13 years agoglsl2: Fix missing visit_continue return in ir_validate.
Eric Anholt [Tue, 27 Jul 2010 07:18:33 +0000 (00:18 -0700)]
glsl2: Fix missing visit_continue return in ir_validate.

13 years agoir_to_mesa: Fix up handling of void function returns.
Eric Anholt [Tue, 27 Jul 2010 02:36:53 +0000 (19:36 -0700)]
ir_to_mesa: Fix up handling of void function returns.

void functions have a type of glsl_type::void_type, not a null type.

13 years agoir_to_mesa: Actually allocate the right size for constant matrix temps.
Eric Anholt [Tue, 27 Jul 2010 02:41:23 +0000 (19:41 -0700)]
ir_to_mesa: Actually allocate the right size for constant matrix temps.

13 years agoir_to_mesa: Add support for structure constants.
Eric Anholt [Tue, 27 Jul 2010 02:08:44 +0000 (19:08 -0700)]
ir_to_mesa: Add support for structure constants.

Fixes:
TPPStreamCompiler::assignOperands

13 years agoglsl2: Also steal the constant components of aggregate-typed ir_constants.
Eric Anholt [Tue, 27 Jul 2010 02:26:53 +0000 (19:26 -0700)]
glsl2: Also steal the constant components of aggregate-typed ir_constants.

13 years agoglsl2: Steal ir_variable's constant_value field.
Kenneth Graunke [Fri, 23 Jul 2010 19:49:17 +0000 (12:49 -0700)]
glsl2: Steal ir_variable's constant_value field.

Fixes a link-time crash in glsl-vs-cross-3.

13 years agoglsl2: Remove old .gitignore file from when we were out of tree.
Eric Anholt [Tue, 27 Jul 2010 00:54:35 +0000 (17:54 -0700)]
glsl2: Remove old .gitignore file from when we were out of tree.

13 years agoMerge remote branch 'origin/master' into glsl2
Eric Anholt [Tue, 27 Jul 2010 00:47:59 +0000 (17:47 -0700)]
Merge remote branch 'origin/master' into glsl2

This pulls in multiple i965 driver fixes which will help ensure better
testing coverage during development, and also gets past the conflicts
of the src/mesa/shader -> src/mesa/program move.

Conflicts:
src/mesa/Makefile
src/mesa/main/shaderapi.c
src/mesa/main/shaderobj.h

13 years agoir_to_mesa: Flag when we use the address reg.
Eric Anholt [Tue, 27 Jul 2010 00:30:35 +0000 (17:30 -0700)]
ir_to_mesa: Flag when we use the address reg.

Hardware backends will get angry otherwise.

13 years agoglx: Remove function prototypes no longer necessary
Kristian Høgsberg [Mon, 26 Jul 2010 21:23:23 +0000 (17:23 -0400)]
glx: Remove function prototypes no longer necessary

13 years agoi965: Fix reversed naming of the operations in compute-to-mrf optimization.
Eric Anholt [Mon, 26 Jul 2010 20:01:45 +0000 (13:01 -0700)]
i965: Fix reversed naming of the operations in compute-to-mrf optimization.

Also fix up comments, so that the difference between the two passes is
clarified.

13 years agoi965: Clean up a few magic numbers to use brw_defines.h defs.
Eric Anholt [Mon, 26 Jul 2010 19:55:28 +0000 (12:55 -0700)]
i965: Clean up a few magic numbers to use brw_defines.h defs.

13 years agoi965: Use MIN2, MAX2 instead of rolling our own.
Eric Anholt [Mon, 26 Jul 2010 19:51:22 +0000 (12:51 -0700)]
i965: Use MIN2, MAX2 instead of rolling our own.

13 years agoi965: Fold the "is arithmetic" bit of 965 opcodes into the opcode list.
Eric Anholt [Mon, 26 Jul 2010 19:49:32 +0000 (12:49 -0700)]
i965: Fold the "is arithmetic" bit of 965 opcodes into the opcode list.

13 years agoi965: Remove some duped register size/count definitions
Eric Anholt [Mon, 26 Jul 2010 19:43:51 +0000 (12:43 -0700)]
i965: Remove some duped register size/count definitions

13 years agoi965: Move the GRF-to-MRF optimizations to brw_optimize.c.
Eric Anholt [Mon, 26 Jul 2010 19:41:39 +0000 (12:41 -0700)]
i965: Move the GRF-to-MRF optimizations to brw_optimize.c.

13 years agoi965: Improve (i.e. remove) some grf-to-mrf unnecessary moves
Benjamin Segovia [Mon, 26 Jul 2010 04:30:19 +0000 (21:30 -0700)]
i965: Improve (i.e. remove) some grf-to-mrf unnecessary moves

Several routines directly analyze the grf-to-mrf moves from the Gen
binary code. When it is possible, the mov is removed and the message
register is directly written in the arithmetic instruction

Also redundant mrf-to-grf moves are removed (frequently for example,
when sampling many textures with the same uv)

Code was tested with piglit, warsow and nexuiz on an Ironlake
machine. No regression was found there

Note that the optimizations are *deactivated* on Gen4 and Gen6 since I
did test them properly yet. No reason there are bugs but who knows

The optimizations are currently done in branch free programs *only*.
Considering branches is more complicated and there are actually two
paths: one for branch free programs and one for programs with branches

Also some other optimizations should be done during the emission
itself but considering that some code is shader between vertex shaders
(AOS) and pixel shaders (SOA) and that we may have branches or not, it
is pretty hard to both factorize the code and have one good set of
strategies

13 years agoglx: Drop debug fprintf that snug in with the previous commit
Kristian Høgsberg [Mon, 26 Jul 2010 20:06:05 +0000 (16:06 -0400)]
glx: Drop debug fprintf that snug in with the previous commit

13 years agoglx: Enable copy subbuffer patch when GLX_DIRECT_RENDERING is #defined
Kristian Høgsberg [Mon, 26 Jul 2010 19:50:02 +0000 (15:50 -0400)]
glx: Enable copy subbuffer patch when GLX_DIRECT_RENDERING is #defined

Depending on __DRI_COPY_SUB_BUFFER doesn't work when we no longer include
dri_interface.h.

https://bugs.freedesktop.org/show_bug.cgi?id=29264

13 years agost/egl: Fix debug line
nobled [Tue, 8 Jun 2010 13:00:17 +0000 (13:00 +0000)]
st/egl: Fix debug line

Acked-by: Jakob Bornecrantz <jakob@vmware.com>
13 years agoutil: fix CPU detection on OS X
nobled [Sat, 24 Jul 2010 12:59:40 +0000 (12:59 +0000)]
util: fix CPU detection on OS X

s/PIPE_OS_DARWIN/PIPE_OS_APPLE, since there is no PIPE_OS_DARWIN.

Acked-by: Vinson Lee <vlee@vmware.com>
13 years agost/xorg: fix use-after-free
nobled [Sat, 24 Jul 2010 12:05:30 +0000 (12:05 +0000)]
st/xorg: fix use-after-free

Acked-by: Jakob Bornecrantz <jakob@vmware.com>
13 years agoi965g: Enable llvm in dri driver if built
Jakob Bornecrantz [Fri, 23 Jul 2010 04:50:27 +0000 (21:50 -0700)]
i965g: Enable llvm in dri driver if built

13 years agoi915g: Fix llvm build
nobled [Sat, 24 Jul 2010 12:04:29 +0000 (12:04 +0000)]
i915g: Fix llvm build

Acked-by: Jakob Bornecrantz <jakob@vmware.com>
13 years agoglx: Drop duplicate psc field in dri context struct
Kristian Høgsberg [Mon, 26 Jul 2010 19:17:00 +0000 (15:17 -0400)]
glx: Drop duplicate psc field in dri context struct

Same problem as fixed for drisw in 4d58b5b482d06ab8d4c4b2db33d0b48b7c82d064.

13 years agoi965: Allow VS MOVs to use immediate constants.
Eric Anholt [Mon, 26 Jul 2010 11:20:33 +0000 (04:20 -0700)]
i965: Allow VS MOVs to use immediate constants.

Clarifies program assembly, and with a little tweak to always use
constant_map, we could cut down on constant buffer payload.

13 years agor600g: implememt the LIT instruction
Stephan Schmid [Mon, 26 Jul 2010 05:52:12 +0000 (07:52 +0200)]
r600g: implememt the LIT instruction

13 years agoutil: fix another mutex leak in mempool
Marek Olšák [Mon, 26 Jul 2010 12:56:48 +0000 (14:56 +0200)]
util: fix another mutex leak in mempool

By fixing one, I introduced another. Crap.

13 years agoutil: fix mutex leaks in mempool
Marek Olšák [Mon, 26 Jul 2010 12:53:06 +0000 (14:53 +0200)]
util: fix mutex leaks in mempool

13 years agor300g: fix macro substitution problem
Dave Airlie [Mon, 26 Jul 2010 01:56:12 +0000 (11:56 +1000)]
r300g: fix macro substitution problem

isn't a problem yet, but have issues in hiz branch.

Signed-off-by: Dave Airlie <airlied@redhat.com>
13 years agor300g: implement D24X8 texture sampling for r3xx-r4xx
Marek Olšák [Sun, 25 Jul 2010 21:40:51 +0000 (23:40 +0200)]
r300g: implement D24X8 texture sampling for r3xx-r4xx

Because the hw can't sample it, I reinterpret the format as G16R16 and
sample the G component. This gives 16 bits of precision, which should be
enough for depth texturing (surprisingly, the sampled values are exactly
the same as in D16 textures).

This also enables EXT_packed_depth_stencil on those old chipsets, finally.

13 years agor300g: make sure a texture is large enough for the CBZB clear
Marek Olšák [Sun, 25 Jul 2010 08:07:12 +0000 (10:07 +0200)]
r300g: make sure a texture is large enough for the CBZB clear

The number of macrotiles in the Y direction must be even, otherwise memory
corruption may happen (e.g. broken fonts). Basically, if we get a buffer
in resource_from_handle, we can determine from the buffer size whether it's
safe to use the CBZB clear or not.

13 years agor300g: do not use TXPITCH_EN if the width is POT and the height is NPOT
Marek Olšák [Sat, 24 Jul 2010 21:05:40 +0000 (23:05 +0200)]
r300g: do not use TXPITCH_EN if the width is POT and the height is NPOT

13 years agor300g: do not use TXPITCH_EN for power-of-two textures from the DDX
Marek Olšák [Sat, 24 Jul 2010 20:52:01 +0000 (22:52 +0200)]
r300g: do not use TXPITCH_EN for power-of-two textures from the DDX

We were using TXPITCH_EN for textures from the DDX since ever, for nothing.

13 years agor300g: cleanup texture creation code
Marek Olšák [Sat, 24 Jul 2010 19:32:53 +0000 (21:32 +0200)]
r300g: cleanup texture creation code

This decouples initializing a texture layout/miptree description
from an actual texture creation, it also partially unifies texture_create
and texture_from_handle.

r300_texture inherits r300_texture_desc, which inherits u_resource.

The CBZB clear criteria are moved to r300_texture_desc::cbzb_allowed[level].

And other minor cleanups.

13 years agor300g: reject resources from handles which are not large enough
Marek Olšák [Sat, 24 Jul 2010 01:34:18 +0000 (03:34 +0200)]
r300g: reject resources from handles which are not large enough

The driver gets a buffer and its size in resource_from_handle.
It computes the required minimum buffer size from given texture
properties, and compares the two sizes.

This is to early detect DDX bugs.

13 years agor300g: cleanup texture debug logging
Marek Olšák [Sat, 24 Jul 2010 01:17:32 +0000 (03:17 +0200)]
r300g: cleanup texture debug logging

13 years agor300g: do not align texture height to 2^n for 1D and 2D non-mipmapped textures
Marek Olšák [Sat, 24 Jul 2010 01:07:45 +0000 (03:07 +0200)]
r300g: do not align texture height to 2^n for 1D and 2D non-mipmapped textures

I don't remember why the alignment was there, but it seems to be
no longer needed. I guess it was a dirty fix for some other bug.

13 years agonvfx: Move declaration before code.
Vinson Lee [Sun, 25 Jul 2010 04:10:45 +0000 (21:10 -0700)]
nvfx: Move declaration before code.

13 years agoglx: Drop duplicate psc field in drisw context struct
Kristian Høgsberg [Sun, 25 Jul 2010 01:43:25 +0000 (21:43 -0400)]
glx: Drop duplicate psc field in drisw context struct

Causing a crash in drisw MakeCurrent.

13 years agoglx: Fix another case of confusing driContext and dri2_context *
Eric Anholt [Fri, 23 Jul 2010 22:02:14 +0000 (15:02 -0700)]
glx: Fix another case of confusing driContext and dri2_context *

13 years agoglx: Correctly look up the dri2 context pointer for SetTexBuffer.
Eric Anholt [Fri, 23 Jul 2010 21:51:06 +0000 (14:51 -0700)]
glx: Correctly look up the dri2 context pointer for SetTexBuffer.

gc->driContext points at the second member of the dri2 context.  The
dri2 context is just a subclass of the GLX context.

Fixes piglit tfp testcase.

13 years agoglx: Don't destroy context with XID 0
Kristian Høgsberg [Sat, 24 Jul 2010 02:05:21 +0000 (22:05 -0400)]
glx: Don't destroy context with XID 0

We use XID 0 to indicate the context has already been destroyed, but it's
currently bound.

13 years agoglx: Fix use after free case when destroying screens
Kristian Høgsberg [Sat, 24 Jul 2010 01:51:58 +0000 (21:51 -0400)]
glx: Fix use after free case when destroying screens