Return scoped_fd from open_source_file and find_and_open_source
authorTom Tromey <tom@tromey.com>
Sat, 27 Oct 2018 18:23:44 +0000 (12:23 -0600)
committerTom Tromey <tom@tromey.com>
Fri, 9 Nov 2018 22:47:45 +0000 (15:47 -0700)
commit2179fbc36d23f29a83fb3dfcac0fc7d1fb31b8e8
tree25112de3c1340c90ca19cefb2dbf5ab5877b6a96
parent9c122c7f9c8260d2cceb1e8f29d69607531f43ba
Return scoped_fd from open_source_file and find_and_open_source

This changes open_source_file and find_and_open_source to return
scoped_fd, then updates the callers as appropriate, including using
scoped_fd::to_file.

Tested by the buildbot.

gdb/ChangeLog
2018-11-09  Tom Tromey  <tom@tromey.com>

* common/scoped_fd.h (class scoped_fd): Add move constructor and
move assignment operator.
* psymtab.c (psymtab_to_fullname): Update.
* source.h (open_source_file): Return scoped_fd.
(find_and_open_source): Likewise.
* source.c (open_source_file): Return scoped_fd.
(get_filename_and_charpos): Update.
(print_source_lines_base): Update.  Use scoped_fd::to_file.
(forward_search_command): Likewise.
(reverse_search_command): Likewise.
(find_and_open_source): Return scoped_fd.
* tui/tui-source.c (tui_set_source_content): Update.  Use
gdb_file_up.
gdb/ChangeLog
gdb/common/scoped_fd.h
gdb/psymtab.c
gdb/source.c
gdb/source.h
gdb/tui/tui-source.c