cso: don't release sampler states that are bound
authorMarek Olšák <marek.olsak@amd.com>
Fri, 2 Dec 2016 14:39:25 +0000 (15:39 +0100)
committerMarek Olšák <marek.olsak@amd.com>
Wed, 7 Dec 2016 17:46:54 +0000 (18:46 +0100)
commit6dc96de303290e8d1fc294da478c4f370be98dea
tree4c1c5d7e8d11a7d94ae6fb0314dca0d6db9b78ab
parente9133dd90ec498cfb6a23fa22504e06488352c51
cso: don't release sampler states that are bound

This fixes random radeonsi GPU hangs in Batman Arkham: Origins (Wine) and
probably many other games too.

cso_cache deletes sampler states when the cache size is too big and doesn't
check which sampler states are bound, causing use-after-free in drivers.
Because of that, radeonsi uploaded garbage sampler states and the hardware
went bananas. Other drivers may have experienced similar issues.

Cc: 12.0 13.0 <mesa-stable@lists.freedesktop.org>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
Reviewed-by: Edward O'Callaghan <funfunctor@folklore1984.net>
src/gallium/auxiliary/cso_cache/cso_cache.c