From a43d379000260485fc4b2b03b069aedc46879557 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Sat, 17 Jun 2017 13:50:30 -0700 Subject: [PATCH] i965/blorp: Set r8stencil_needs_update when writing stencil This fixes a crash on Haswell when we try to upload a stencil texture with blorp. It would also be a problem if someone tried to texture from stencil after glBlitFramebuffers. Cc: "17.2 17.1" Reviewed-by: Kenneth Graunke Reviewed-by: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_blorp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 4c6ae369196..0c58e74b67d 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c +++ b/src/mesa/drivers/dri/i965/brw_blorp.c @@ -135,6 +135,8 @@ blorp_surf_for_miptree(struct brw_context *brw, unsigned start_layer, unsigned num_layers, struct isl_surf tmp_surfs[1]) { + const struct gen_device_info *devinfo = &brw->screen->devinfo; + if (mt->surf.msaa_layout == ISL_MSAA_LAYOUT_ARRAY) { const unsigned num_samples = mt->surf.samples; for (unsigned i = 0; i < num_layers; i++) { @@ -163,6 +165,10 @@ blorp_surf_for_miptree(struct brw_context *brw, else if (mt->hiz_buf) aux_surf = &mt->hiz_buf->surf; + if (mt->format == MESA_FORMAT_S_UINT8 && is_render_target && + devinfo->gen <= 7) + mt->r8stencil_needs_update = true; + if (surf->aux_usage == ISL_AUX_USAGE_HIZ && !intel_miptree_level_has_hiz(mt, *level)) surf->aux_usage = ISL_AUX_USAGE_NONE; -- 2.30.2