From aa675cef5e589bb1f4dacb94e22d8195f1d7e5ac Mon Sep 17 00:00:00 2001 From: Caio Marcelo de Oliveira Filho Date: Wed, 1 May 2019 16:31:14 -0700 Subject: [PATCH] intel/fs: Assert when brw_fs_nir sees a nir_deref_instr Since 09f1de97a76 "anv,i965: Lower away image derefs in the driver" the backend compiler is not expected to handle any derefs, so let's assert on it. This helps identifying problems when a deref is not lowered and "leaks" into the backend compiler. Reviewed-by: Jason Ekstrand --- src/intel/compiler/brw_fs_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index 526cc13c71a..cdd3f7bccaa 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++ b/src/intel/compiler/brw_fs_nir.cpp @@ -454,7 +454,7 @@ fs_visitor::nir_emit_instr(nir_instr *instr) break; case nir_instr_type_deref: - /* Derefs can exist for images but they do nothing */ + unreachable("All derefs should've been lowered"); break; case nir_instr_type_intrinsic: -- 2.30.2