From 002ff5bc3ea7c58a574c64e4d45d58ff60c6171b Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Wed, 29 May 2002 13:29:21 -0700 Subject: [PATCH] i386.c (ix86_compute_frame_layout): Do add bottom alignment for alloca. * config/i386/i386.c (ix86_compute_frame_layout): Do add bottom alignment for alloca. * gcc.c-torture/execute/alloca-1.c: New. From-SVN: r54018 --- gcc/ChangeLog | 5 +++++ gcc/config/i386/i386.c | 5 +++-- .../gcc.c-torture/execute/alloca-1.c | 21 +++++++++++++++++++ 3 files changed, 29 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.c-torture/execute/alloca-1.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index a7619317330..14069a7f6b1 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2002-05-29 Richard Henderson + + * config/i386/i386.c (ix86_compute_frame_layout): Do add bottom + alignment for alloca. + 2002-05-29 Richard Henderson * config/i386/i386.c (output_pic_addr_const): Lowercase rip. diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 5170c99a4c8..877f3554ffb 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -4148,8 +4148,9 @@ ix86_compute_frame_layout (frame) else frame->outgoing_arguments_size = 0; - /* Align stack boundary. Only needed if we're calling another function. */ - if (!current_function_is_leaf) + /* Align stack boundary. Only needed if we're calling another function + or using alloca. */ + if (!current_function_is_leaf || current_function_calls_alloca) frame->padding2 = ((offset + preferred_alignment - 1) & -preferred_alignment) - offset; else diff --git a/gcc/testsuite/gcc.c-torture/execute/alloca-1.c b/gcc/testsuite/gcc.c-torture/execute/alloca-1.c new file mode 100644 index 00000000000..a8d1384c6ec --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/alloca-1.c @@ -0,0 +1,21 @@ +/* Verify that alloca storage is sufficiently aligned. */ +/* ??? May fail if BIGGEST_ALIGNMENT > STACK_BOUNDARY. Which, I guess + can only happen on !STRICT_ALIGNMENT targets. */ + +typedef __SIZE_TYPE__ size_t; + +struct dummy { int x __attribute__((aligned)); }; +#define BIGGEST_ALIGNMENT __alignof__(struct dummy) + +_Bool foo(void) +{ + char *p = __builtin_alloca(32); + return ((size_t)p & (BIGGEST_ALIGNMENT - 1)) == 0; +} + +int main() +{ + if (!foo()) + abort (); + return 0; +} -- 2.30.2