From 0039fa5565d141f17b2517100a32694c18504802 Mon Sep 17 00:00:00 2001 From: Adam Nemet Date: Thu, 28 Oct 2004 19:30:49 +0000 Subject: [PATCH] re PR middle-end/18160 (ICE on taking register variable address) PR middle-end/18160 * c-typeck.c (c_mark_addressable): Issue error if address of a register variable is taken. Use "%qD" to print DECL_NAME. From-SVN: r89772 --- gcc/ChangeLog | 6 ++++++ gcc/c-typeck.c | 23 +++++++++-------------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index d19df0ed993..0aa6c693104 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2004-10-28 Adam Nemet + + PR middle-end/18160 + * c-typeck.c (c_mark_addressable): Issue error if address of a + register variable is taken. Use "%qD" to print DECL_NAME. + 2004-10-28 Diego Novillo * opts.c (decode_options): Don't run PRE at -Os. diff --git a/gcc/c-typeck.c b/gcc/c-typeck.c index 9e4f0fb1501..7d599bce05c 100644 --- a/gcc/c-typeck.c +++ b/gcc/c-typeck.c @@ -2818,8 +2818,8 @@ c_mark_addressable (tree exp) case COMPONENT_REF: if (DECL_C_BIT_FIELD (TREE_OPERAND (x, 1))) { - error ("cannot take address of bit-field %qs", - IDENTIFIER_POINTER (DECL_NAME (TREE_OPERAND (x, 1)))); + error + ("cannot take address of bit-field %qD", TREE_OPERAND (x, 1)); return false; } @@ -2846,24 +2846,19 @@ c_mark_addressable (tree exp) { if (TREE_PUBLIC (x) || TREE_STATIC (x) || DECL_EXTERNAL (x)) { - error ("global register variable %qs used in nested function", - IDENTIFIER_POINTER (DECL_NAME (x))); + error + ("global register variable %qD used in nested function", x); return false; } - pedwarn ("register variable %qs used in nested function", - IDENTIFIER_POINTER (DECL_NAME (x))); + pedwarn ("register variable %qD used in nested function", x); } else if (C_DECL_REGISTER (x)) { if (TREE_PUBLIC (x) || TREE_STATIC (x) || DECL_EXTERNAL (x)) - { - error ("address of global register variable %qs requested", - IDENTIFIER_POINTER (DECL_NAME (x))); - return false; - } - - pedwarn ("address of register variable %qs requested", - IDENTIFIER_POINTER (DECL_NAME (x))); + error ("address of global register variable %qD requested", x); + else + error ("address of register variable %qD requested", x); + return false; } /* drops in */ -- 2.30.2