From 00be5d7b82763040cc79770b12d0b6e8d47e684d Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Tue, 20 Aug 2019 13:19:40 -0700 Subject: [PATCH] pan/decode: Guard attribute unknowns One should be zero. The other has always been seen as set, so check this. Signed-off-by: Alyssa Rosenzweig --- src/panfrost/pandecode/decode.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/panfrost/pandecode/decode.c b/src/panfrost/pandecode/decode.c index 08f67e2ee84..fe0c33048c3 100644 --- a/src/panfrost/pandecode/decode.c +++ b/src/panfrost/pandecode/decode.c @@ -1396,8 +1396,16 @@ pandecode_attribute_meta(int job_no, int count, const struct mali_vertex_tiler_p pandecode_swizzle(attr_meta->swizzle); pandecode_prop("format = %s", pandecode_format(attr_meta->format)); - pandecode_prop("unknown1 = 0x%" PRIx64, (u64) attr_meta->unknown1); - pandecode_prop("unknown3 = 0x%" PRIx64, (u64) attr_meta->unknown3); + if (attr_meta->unknown1 != 0x2) { + pandecode_msg("XXX: expected unknown1 = 0x2\n"); + pandecode_prop("unknown1 = 0x%" PRIx64, (u64) attr_meta->unknown1); + } + + if (attr_meta->unknown3) { + pandecode_msg("XXX: unexpected unknown3 set\n"); + pandecode_prop("unknown3 = 0x%" PRIx64, (u64) attr_meta->unknown3); + } + pandecode_prop("src_offset = %d", attr_meta->src_offset); pandecode_indent--; pandecode_log("},\n"); -- 2.30.2