From 014d61ea14540cc524a6f75d2b925e7bb1a6d289 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Tue, 16 Feb 2021 11:32:18 +0100 Subject: [PATCH] x86: record register use for SIMD insns without respective explicit operands VZERO{ALL,UPPER} modify YMM registers despite having no operands. While {,V}{LD,ST}MXCSR don't modify XMM registers, MXCSR and XMMn collectively form underlying machine state. --- gas/ChangeLog | 12 ++++++++++++ gas/config/tc-i386.c | 12 ++++++++++++ gas/testsuite/gas/i386/i386.exp | 3 +++ gas/testsuite/gas/i386/property-ldmxcsr.d | 9 +++++++++ gas/testsuite/gas/i386/property-ldmxcsr.s | 2 ++ gas/testsuite/gas/i386/property-vldmxcsr.d | 9 +++++++++ gas/testsuite/gas/i386/property-vldmxcsr.s | 2 ++ gas/testsuite/gas/i386/property-vzeroall.d | 9 +++++++++ gas/testsuite/gas/i386/property-vzeroall.s | 2 ++ 9 files changed, 60 insertions(+) create mode 100644 gas/testsuite/gas/i386/property-ldmxcsr.d create mode 100644 gas/testsuite/gas/i386/property-ldmxcsr.s create mode 100644 gas/testsuite/gas/i386/property-vldmxcsr.d create mode 100644 gas/testsuite/gas/i386/property-vldmxcsr.s create mode 100644 gas/testsuite/gas/i386/property-vzeroall.d create mode 100644 gas/testsuite/gas/i386/property-vzeroall.s diff --git a/gas/ChangeLog b/gas/ChangeLog index 12ce28b8db7..a269303e080 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,15 @@ +2021-02-16 Jan Beulich + + * config/tc-i386.c (output_insn): Handle ldmxcsr, stmxcsr, + vldmxcsr, vstmxcsr, vzeroall, and vzeroupper. + * testsuite/gas/i386/property-ldmxcsr.s, + testsuite/gas/i386/property-ldmxcsr.d, + testsuite/gas/i386/property-vldmxcsr.s, + testsuite/gas/i386/property-vldmxcsr.d, + testsuite/gas/i386/property-vzeroall.s, + testsuite/gas/i386/property-vzeroall.d: New. + * testsuite/gas/i386/i386.exp: Run new tests. + 2021-02-16 Jan Beulich * testsuite/gas/i386/i386.exp: Move bitness-independent property diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index b0140e1128a..94783f51550 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -9208,10 +9208,12 @@ output_insn (void) || i.tm.cpu_flags.bitfield.cpu687 || i.tm.cpu_flags.bitfield.cpufisttp) x86_feature_2_used |= GNU_PROPERTY_X86_FEATURE_2_X87; + if ((i.xstate & xstate_mmx) || i.tm.base_opcode == 0xf77 /* emms */ || i.tm.base_opcode == 0xf0e /* femms */) x86_feature_2_used |= GNU_PROPERTY_X86_FEATURE_2_MMX; + if (i.index_reg) { if (i.index_reg->reg_type.bitfield.zmmword) @@ -9221,10 +9223,20 @@ output_insn (void) else if (i.index_reg->reg_type.bitfield.xmmword) i.xstate |= xstate_xmm; } + + /* vzeroall / vzeroupper */ + if (i.tm.base_opcode == 0x77 && i.tm.cpu_flags.bitfield.cpuavx) + i.xstate |= xstate_ymm; + if ((i.xstate & xstate_xmm) + /* ldmxcsr / stmxcsr */ + || (i.tm.base_opcode == 0xfae && i.tm.cpu_flags.bitfield.cpusse) + /* vldmxcsr / vstmxcsr */ + || (i.tm.base_opcode == 0xae && i.tm.cpu_flags.bitfield.cpuavx) || i.tm.cpu_flags.bitfield.cpuwidekl || i.tm.cpu_flags.bitfield.cpukl) x86_feature_2_used |= GNU_PROPERTY_X86_FEATURE_2_XMM; + if ((i.xstate & xstate_ymm) == xstate_ymm) x86_feature_2_used |= GNU_PROPERTY_X86_FEATURE_2_YMM; if ((i.xstate & xstate_zmm) == xstate_zmm) diff --git a/gas/testsuite/gas/i386/i386.exp b/gas/testsuite/gas/i386/i386.exp index 5a481a4c47a..89f62b3aeca 100644 --- a/gas/testsuite/gas/i386/i386.exp +++ b/gas/testsuite/gas/i386/i386.exp @@ -725,6 +725,9 @@ if {[is_elf_format] || [istarget "*-*-vxworks*"]} then { run_dump_test "property-11" run_dump_test "property-12" run_dump_test "property-13" + run_dump_test "property-ldmxcsr" + run_dump_test "property-vldmxcsr" + run_dump_test "property-vzeroall" if {![istarget "*-*-dragonfly*"] && ![istarget "*-*-gnu*"] diff --git a/gas/testsuite/gas/i386/property-ldmxcsr.d b/gas/testsuite/gas/i386/property-ldmxcsr.d new file mode 100644 index 00000000000..7fb546e4214 --- /dev/null +++ b/gas/testsuite/gas/i386/property-ldmxcsr.d @@ -0,0 +1,9 @@ +#name: i386 property ldmxcsr +#as: -mx86-used-note=yes --generate-missing-build-notes=no +#readelf: -n + +Displaying notes found in: .note.gnu.property +[ ]+Owner[ ]+Data size[ ]+Description + GNU 0x[0-9a-f]+ NT_GNU_PROPERTY_TYPE_0 + Properties: x86 ISA used: x86-64-baseline + x86 feature used: x86, XMM diff --git a/gas/testsuite/gas/i386/property-ldmxcsr.s b/gas/testsuite/gas/i386/property-ldmxcsr.s new file mode 100644 index 00000000000..8a8a39926d8 --- /dev/null +++ b/gas/testsuite/gas/i386/property-ldmxcsr.s @@ -0,0 +1,2 @@ + .text + ldmxcsr (%eax) diff --git a/gas/testsuite/gas/i386/property-vldmxcsr.d b/gas/testsuite/gas/i386/property-vldmxcsr.d new file mode 100644 index 00000000000..b913b11f7f6 --- /dev/null +++ b/gas/testsuite/gas/i386/property-vldmxcsr.d @@ -0,0 +1,9 @@ +#name: i386 property vldmxcsr +#as: -mx86-used-note=yes --generate-missing-build-notes=no +#readelf: -n + +Displaying notes found in: .note.gnu.property +[ ]+Owner[ ]+Data size[ ]+Description + GNU 0x[0-9a-f]+ NT_GNU_PROPERTY_TYPE_0 + Properties: x86 ISA used: x86-64-baseline, x86-64-v3 + x86 feature used: x86, XMM diff --git a/gas/testsuite/gas/i386/property-vldmxcsr.s b/gas/testsuite/gas/i386/property-vldmxcsr.s new file mode 100644 index 00000000000..69071fe416b --- /dev/null +++ b/gas/testsuite/gas/i386/property-vldmxcsr.s @@ -0,0 +1,2 @@ + .text + vldmxcsr (%eax) diff --git a/gas/testsuite/gas/i386/property-vzeroall.d b/gas/testsuite/gas/i386/property-vzeroall.d new file mode 100644 index 00000000000..e1faee47259 --- /dev/null +++ b/gas/testsuite/gas/i386/property-vzeroall.d @@ -0,0 +1,9 @@ +#name: i386 property vzeroall +#as: -mx86-used-note=yes --generate-missing-build-notes=no +#readelf: -n + +Displaying notes found in: .note.gnu.property +[ ]+Owner[ ]+Data size[ ]+Description + GNU 0x[0-9a-f]+ NT_GNU_PROPERTY_TYPE_0 + Properties: x86 ISA used: x86-64-baseline, x86-64-v3 + x86 feature used: x86, XMM, YMM diff --git a/gas/testsuite/gas/i386/property-vzeroall.s b/gas/testsuite/gas/i386/property-vzeroall.s new file mode 100644 index 00000000000..ec83d6bfd1c --- /dev/null +++ b/gas/testsuite/gas/i386/property-vzeroall.s @@ -0,0 +1,2 @@ + .text + vzeroall -- 2.30.2