From 01dd363e671ac3a457bc3ff60b43b04e108c33fc Mon Sep 17 00:00:00 2001 From: Arda Coskunses Date: Thu, 22 Dec 2016 14:55:03 -0700 Subject: [PATCH] vulkan/wsi/x11: don't crash on null visual When application window closed unexpectedly due to lost window visualtypes getting invlaid parameters which is causing a crash. Necessary check is added to prevent the crash. Reviewed-by: Jason Ekstrand Cc: "13.0" --- src/vulkan/wsi/wsi_common_x11.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index 25ba0c1b8ae..037aa50ba2a 100644 --- a/src/vulkan/wsi/wsi_common_x11.c +++ b/src/vulkan/wsi/wsi_common_x11.c @@ -349,6 +349,9 @@ x11_surface_get_capabilities(VkIcdSurfaceBase *icd_surface, xcb_visualtype_t *visual = get_visualtype_for_window(conn, window, &visual_depth); + if (!visual) + return VK_ERROR_SURFACE_LOST_KHR; + geom = xcb_get_geometry_reply(conn, geom_cookie, &err); if (geom) { VkExtent2D extent = { geom->width, geom->height }; -- 2.30.2