From 02349803fc5a7941b4e23d1580bd8b600d6be1bd Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 22 Jan 2021 12:40:48 -0500 Subject: [PATCH] gdb: change remote_debug to bool As far as I can see, there are no more spots looking for a remote_debug other than true/false. If we ever want to revert to an int, we can always change it back later, but this makes things simpler for now. gdb/ChangeLog: * remote.h (remote_debug): Change to bool. * remote.c (remote_debug): Change to bool. (_initialize_remote): Adjust. Change-Id: I21aac5b4cff9dc4f75c8efaf47c23583ecabd2a6 --- gdb/ChangeLog | 6 ++++++ gdb/remote.c | 15 ++++++++------- gdb/remote.h | 6 +++--- 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ceb6b103f30..8efc9da9092 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2021-01-22 Simon Marchi + + * remote.h (remote_debug): Change to bool. + * remote.c (remote_debug): Change to bool. + (_initialize_remote): Adjust. + 2021-01-22 Simon Marchi * target.h (remote_debug): Move to... diff --git a/gdb/remote.c b/gdb/remote.c index 79ce6a34463..70d5e886010 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -89,7 +89,7 @@ Specify the serial device it is connected to\n\ /* See remote.h */ -int remote_debug = 0; +bool remote_debug = false; #define OPAQUETHREADBYTES 8 @@ -15062,14 +15062,15 @@ Specify \"unlimited\" to display all the characters."), NULL, show_remote_packet_max_chars, &setdebuglist, &showdebuglist); - add_setshow_zinteger_cmd ("remote", no_class, &remote_debug, _("\ -Set debugging of remote protocol."), _("\ -Show debugging of remote protocol."), _("\ + add_setshow_boolean_cmd ("remote", no_class, &remote_debug, + _("Set debugging of remote protocol."), + _("Show debugging of remote protocol."), + _("\ When enabled, each packet sent or received with the remote target\n\ is displayed."), - NULL, - show_remote_debug, - &setdebuglist, &showdebuglist); + NULL, + show_remote_debug, + &setdebuglist, &showdebuglist); add_setshow_zuinteger_unlimited_cmd ("remotetimeout", no_class, &remote_timeout, _("\ diff --git a/gdb/remote.h b/gdb/remote.h index de582a2dd4c..1f6916c3200 100644 --- a/gdb/remote.h +++ b/gdb/remote.h @@ -24,9 +24,9 @@ struct target_desc; struct remote_target; -/* Debugging level. 0 is off, and non-zero values mean to print some debug - information (higher values, more information). */ -extern int remote_debug; +/* True when printing "remote" debug statements is enabled. */ + +extern bool remote_debug; /* Read a packet from the remote machine, with error checking, and store it in *BUF. Resize *BUF using xrealloc if necessary to hold -- 2.30.2