From 02765a37a16527a510600c206bb0fe176d255525 Mon Sep 17 00:00:00 2001 From: Richard Guenther Date: Tue, 8 Apr 2008 21:57:43 +0000 Subject: [PATCH] fold-const.c (fold_widened_comparison): Do not allow sign-changes that change the result. 2008-04-08 Richard Guenther * fold-const.c (fold_widened_comparison): Do not allow sign-changes that change the result. * gcc.c-torture/execute/20080408-1.c: New testcase. From-SVN: r134108 --- gcc/ChangeLog | 5 +++++ gcc/fold-const.c | 6 +++++- gcc/testsuite/ChangeLog | 4 ++++ gcc/testsuite/gcc.c-torture/execute/20080408-1.c | 11 +++++++++++ 4 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.c-torture/execute/20080408-1.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c7b8ad017f9..1151620508e 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2008-04-08 Richard Guenther + + * fold-const.c (fold_widened_comparison): Do not allow + sign-changes that change the result. + 2008-04-08 Janis Johnson PR target/35839 diff --git a/gcc/fold-const.c b/gcc/fold-const.c index 26550b91169..66e72a7d0ad 100644 --- a/gcc/fold-const.c +++ b/gcc/fold-const.c @@ -6721,7 +6721,11 @@ fold_widened_comparison (enum tree_code code, tree type, tree arg0, tree arg1) || TYPE_UNSIGNED (TREE_TYPE (arg0)) == TYPE_UNSIGNED (shorter_type)) && (TREE_TYPE (arg1_unw) == shorter_type || (TYPE_PRECISION (shorter_type) - >= TYPE_PRECISION (TREE_TYPE (arg1_unw))) + > TYPE_PRECISION (TREE_TYPE (arg1_unw))) + || ((TYPE_PRECISION (shorter_type) + == TYPE_PRECISION (TREE_TYPE (arg1_unw))) + && (TYPE_UNSIGNED (shorter_type) + == TYPE_UNSIGNED (TREE_TYPE (arg1_unw)))) || (TREE_CODE (arg1_unw) == INTEGER_CST && (TREE_CODE (shorter_type) == INTEGER_TYPE || TREE_CODE (shorter_type) == BOOLEAN_TYPE) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 89353a74787..be299964316 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2008-04-08 Richard Guenther + + * gcc.c-torture/execute/20080408-1.c: New testcase. + 2008-04-08 Eric Botcazou * gnat.dg/pack6.adb: New test. diff --git a/gcc/testsuite/gcc.c-torture/execute/20080408-1.c b/gcc/testsuite/gcc.c-torture/execute/20080408-1.c new file mode 100644 index 00000000000..9e1ff639517 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/20080408-1.c @@ -0,0 +1,11 @@ +extern void abort (void); +int main () +{ + short ssi = 126; + unsigned short usi = 65280; + int fail = !(ssi < usi); + if (fail) + abort (); + return 0; +} + -- 2.30.2