From 02d868e86d67fb808a08df5fcd6446fbb8b16288 Mon Sep 17 00:00:00 2001 From: Paul Pluzhnikov Date: Sat, 31 Jul 2010 15:34:41 +0000 Subject: [PATCH] 2010-07-31 Paul Pluzhnikov * linux-thread-db.c (libthread_db_debug): New variable. (thread_db_find_new_threads_silently): Control verbosity with it. (try_thread_db_load_1, try_thread_db_load): Likewise. (find_new_threads_once): Likewise. (_initialize_thread_db): Set/show it. doc/ChangeLog 2010-07-31 Paul Pluzhnikov * gdb.texinfo (Threads): Document 'debug libthread-db'. --- gdb/ChangeLog | 8 ++++++++ gdb/doc/ChangeLog | 4 ++++ gdb/doc/gdb.texinfo | 8 ++++++++ gdb/linux-thread-db.c | 36 +++++++++++++++++++++++++++++------- 4 files changed, 49 insertions(+), 7 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index bcb08bad231..cfb5163c894 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2010-07-31 Paul Pluzhnikov + + * linux-thread-db.c (libthread_db_debug): New variable. + (thread_db_find_new_threads_silently): Control verbosity with it. + (try_thread_db_load_1, try_thread_db_load): Likewise. + (find_new_threads_once): Likewise. + (_initialize_thread_db): Set/show it. + 2010-07-31 Jan Kratochvil * common/signals.c (signals): Move the content to signals.def. diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 6253af46ec1..f0f515ca883 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,7 @@ +2010-07-31 Paul Pluzhnikov + + * gdb.texinfo (Threads): Document 'debug libthread-db'. + 2010-07-30 Tom Tromey * gdb.texinfo (Index Files): Mention gdb-add-index. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index b49b53ecc13..03b59a3ee07 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -2864,6 +2864,14 @@ only on some platforms. @kindex show libthread-db-search-path @item show libthread-db-search-path Display current libthread_db search path. + +@kindex set debug libthread-db +@kindex show debug libthread-db +@cindex debugging @code{libthread_db} +@item set debug libthread-db +@itemx show debug libthread-db +Turns on or off display of @code{libthread_db}-related events. +Use @code{1} to enable, @code{0} to disable. @end table @node Forks diff --git a/gdb/linux-thread-db.c b/gdb/linux-thread-db.c index 6cbf6c3d396..a8abd69d405 100644 --- a/gdb/linux-thread-db.c +++ b/gdb/linux-thread-db.c @@ -75,6 +75,18 @@ static char *libthread_db_search_path; +/* If non-zero, print details of libthread_db processing. */ + +static int libthread_db_debug; + +static void +show_libthread_db_debug (struct ui_file *file, int from_tty, + struct cmd_list_element *c, const char *value) +{ + fprintf_filtered (file, _("libthread-db debugging is %s.\n"), value); +} + + /* If we're running on GNU/Linux, we must explicitly attach to any new threads. */ @@ -601,7 +613,7 @@ thread_db_find_new_threads_silently (ptid_t ptid) thread_db_find_new_threads_2 (ptid, 1); } - if (except.reason < 0 && info_verbose) + if (except.reason < 0 && libthread_db_debug) { exception_fprintf (gdb_stderr, except, "Warning: thread_db_find_new_threads_silently: "); @@ -658,7 +670,7 @@ try_thread_db_load_1 (struct thread_db_info *info) err = info->td_ta_new_p (&info->proc_handle, &info->thread_agent); if (err != TD_OK) { - if (info_verbose) + if (libthread_db_debug) printf_unfiltered (_("td_ta_new failed: %s\n"), thread_db_err_str (err)); else @@ -708,7 +720,7 @@ try_thread_db_load_1 (struct thread_db_info *info) printf_unfiltered (_("[Thread debugging using libthread_db enabled]\n")); - if (info_verbose || *libthread_db_search_path) + if (libthread_db_debug || *libthread_db_search_path) { const char *library; @@ -745,18 +757,18 @@ try_thread_db_load (const char *library) void *handle; struct thread_db_info *info; - if (info_verbose) + if (libthread_db_debug) printf_unfiltered (_("Trying host libthread_db library: %s.\n"), library); handle = dlopen (library, RTLD_NOW); if (handle == NULL) { - if (info_verbose) + if (libthread_db_debug) printf_unfiltered (_("dlopen failed: %s.\n"), dlerror ()); return 0; } - if (info_verbose && strchr (library, '/') == NULL) + if (libthread_db_debug && strchr (library, '/') == NULL) { void *td_init; @@ -1381,7 +1393,7 @@ find_new_threads_once (struct thread_db_info *info, int iteration, TD_THR_ANY_USER_FLAGS); } - if (info_verbose) + if (libthread_db_debug) { if (except.reason < 0) exception_fprintf (gdb_stderr, except, @@ -1685,6 +1697,16 @@ gdb itself."), NULL, NULL, &setlist, &showlist); + + add_setshow_zinteger_cmd ("libthread-db", class_maintenance, + &libthread_db_debug, _("\ +Set libthread-db debugging."), _("\ +Show libthread-db debugging."), _("\ +When non-zero, libthread-db debugging is enabled."), + NULL, + show_libthread_db_debug, + &setdebuglist, &showdebuglist); + /* Add ourselves to objfile event chain. */ observer_attach_new_objfile (thread_db_new_objfile); } -- 2.30.2