From 035bf2198368d3fa69387788a63039d71319f0bf Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Thu, 1 Aug 2013 23:04:27 -0700 Subject: [PATCH] i915,i965: Fix memory leak in try_pbo_upload (v2) Fixes "Resource leak" defect reported by Coverity. Tested on Haswell, no Piglit regressions. v2: Apply to i965, not just i915. (chadv) CC: "9.2, 9.1" Signed-off-by: Vinson Lee Reviewed-by: Chad Versace --- src/mesa/drivers/dri/i915/intel_tex_image.c | 1 + src/mesa/drivers/dri/i965/intel_tex_image.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i915/intel_tex_image.c b/src/mesa/drivers/dri/i915/intel_tex_image.c index 9b1336d7593..975e77aa572 100644 --- a/src/mesa/drivers/dri/i915/intel_tex_image.c +++ b/src/mesa/drivers/dri/i915/intel_tex_image.c @@ -171,6 +171,7 @@ try_pbo_upload(struct gl_context *ctx, 0, 0, false, image->Width, image->Height, GL_COPY)) { DBG("%s: blit failed\n", __FUNCTION__); + intel_miptree_release(&pbo_mt); return false; } diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c index 7db0deb50db..f270862b65d 100644 --- a/src/mesa/drivers/dri/i965/intel_tex_image.c +++ b/src/mesa/drivers/dri/i965/intel_tex_image.c @@ -173,6 +173,7 @@ try_pbo_upload(struct gl_context *ctx, 0, 0, false, image->Width, image->Height, GL_COPY)) { DBG("%s: blit failed\n", __FUNCTION__); + intel_miptree_release(&pbo_mt); return false; } -- 2.30.2