From 037f11d42ec2bb6812f4cc51dffff3916fccf62a Mon Sep 17 00:00:00 2001 From: Rhys Perry Date: Thu, 6 Dec 2018 13:33:48 +0000 Subject: [PATCH] radv: enable VK_KHR_8bit_storage Signed-off-by: Rhys Perry Reviewed-by: Bas Nieuwenhuizen --- docs/features.txt | 2 +- src/amd/vulkan/radv_device.c | 9 +++++++++ src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_shader.c | 1 + 4 files changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 6c2b6d59377..ded753b0182 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -439,7 +439,7 @@ Vulkan 1.1 -- all DONE: anv, radv VK_KHR_variable_pointers DONE (anv, radv) Khronos extensions that are not part of any Vulkan version: - VK_KHR_8bit_storage DONE (anv) + VK_KHR_8bit_storage DONE (anv, radv) VK_KHR_android_surface not started VK_KHR_create_renderpass2 DONE (anv, radv) VK_KHR_display DONE (anv, radv) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 5a54c5842ab..433b8542029 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -895,6 +895,15 @@ void radv_GetPhysicalDeviceFeatures2( features->hostQueryReset = true; break; } + case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES_KHR: { + VkPhysicalDevice8BitStorageFeaturesKHR *features = + (VkPhysicalDevice8BitStorageFeaturesKHR*)ext; + bool enabled = pdevice->rad_info.chip_class >= VI; + features->storageBuffer8BitAccess = enabled; + features->uniformAndStorageBuffer8BitAccess = enabled; + features->storagePushConstant8 = enabled; + break; + } default: break; } diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py index 88d5780fe8d..421f8b926ea 100644 --- a/src/amd/vulkan/radv_extensions.py +++ b/src/amd/vulkan/radv_extensions.py @@ -92,6 +92,7 @@ EXTENSIONS = [ Extension('VK_KHR_xlib_surface', 6, 'VK_USE_PLATFORM_XLIB_KHR'), Extension('VK_KHR_multiview', 1, True), Extension('VK_KHR_display', 23, 'VK_USE_PLATFORM_DISPLAY_KHR'), + Extension('VK_KHR_8bit_storage', 1, 'device->rad_info.chip_class >= VI'), Extension('VK_EXT_direct_mode_display', 1, 'VK_USE_PLATFORM_DISPLAY_KHR'), Extension('VK_EXT_acquire_xlib_display', 1, 'VK_USE_PLATFORM_XLIB_XRANDR_EXT'), Extension('VK_EXT_buffer_device_address', 1, True), diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index a1612c829b8..eecbc6ae759 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -249,6 +249,7 @@ radv_shader_compile_to_nir(struct radv_device *device, .transform_feedback = true, .trinary_minmax = true, .variable_pointers = true, + .storage_8bit = true, }, .ubo_ptr_type = glsl_vector_type(GLSL_TYPE_UINT, 2), .ssbo_ptr_type = glsl_vector_type(GLSL_TYPE_UINT, 2), -- 2.30.2