From 039298ec451ecf1fa1b9ff1771168b0a5b3a6f68 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Tue, 12 Nov 2019 17:02:49 -0700 Subject: [PATCH] Remove some TUI asserts This removes a few asserts from the TUI. These asserts aren't useful, because they simply check an invariant that's already ensured by the type system. gdb/ChangeLog 2019-12-20 Tom Tromey * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at) (tui_source_window_base::update_breakpoint_info): Remove asserts. Change-Id: I807e1e9bdb0cfa475e70375ceca3a5d4f2eb8d0b --- gdb/ChangeLog | 5 +++++ gdb/tui/tui-winsource.c | 6 ------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 7c518ca7bb9..1fc603d8d60 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-12-20 Tom Tromey + + * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at) + (tui_source_window_base::update_breakpoint_info): Remove asserts. + 2019-12-20 Tom Tromey * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c index 06c00fa2b80..fe1eb8fc333 100644 --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -449,9 +449,6 @@ tui_source_window_base::set_is_exec_point_at (struct tui_line_or_address l) struct tui_line_or_address content_loa = content[i].line_or_addr; - gdb_assert (l.loa == LOA_ADDRESS || l.loa == LOA_LINE); - gdb_assert (content_loa.loa == LOA_LINE - || content_loa.loa == LOA_ADDRESS); if (content_loa.loa == l.loa && ((l.loa == LOA_LINE && content_loa.u.line_no == l.u.line_no) || (l.loa == LOA_ADDRESS && content_loa.u.addr == l.u.addr))) @@ -512,9 +509,6 @@ tui_source_window_base::update_breakpoint_info { struct bp_location *loc; - gdb_assert (line->line_or_addr.loa == LOA_LINE - || line->line_or_addr.loa == LOA_ADDRESS); - if (bp == being_deleted) return false; -- 2.30.2