From 03b0a45f15e44da7983dffea921c0c43a19250ff Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Tue, 8 Sep 2020 10:35:22 -0600 Subject: [PATCH] Fix uninitialized warning in gdb_bfd_open The previous patch introduced an uninitialized warning in gdb_bfd_open. The problem was that "abfd" was being used without being initialized. This patch fixes the problem by calling bfd_fopen in the branch where "fstat" has failed. gdb/ChangeLog 2020-09-08 Tom Tromey * gdb_bfd.c (gdb_bfd_open): Call bfd_fopen when fstat fails. --- gdb/ChangeLog | 4 ++++ gdb/gdb_bfd.c | 8 +++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 01daa99869b..c8d46901c9f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-09-08 Tom Tromey + + * gdb_bfd.c (gdb_bfd_open): Call bfd_fopen when fstat fails. + 2020-09-08 Tom Tromey PR win32/25302: diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c index 15bf9f79c20..58d177cf7df 100644 --- a/gdb/gdb_bfd.c +++ b/gdb/gdb_bfd.c @@ -445,9 +445,11 @@ gdb_bfd_open (const char *name, const char *target, int fd, /* Weird situation here -- don't cache if we can't stat. */ if (debug_bfd_cache) fprintf_unfiltered (gdb_stdlog, - "Could not stat bfd %s for %s - not caching\n", - host_address_to_string (abfd), - bfd_get_filename (abfd)); + "Could not stat %s - not caching\n", + name); + abfd = bfd_fopen (name, target, FOPEN_RB, fd); + if (abfd == nullptr) + return nullptr; return gdb_bfd_ref_ptr::new_reference (abfd); } -- 2.30.2