From 04d91c807eaf4395472409a53e2acd9ad89683f0 Mon Sep 17 00:00:00 2001 From: Nick Alcock Date: Mon, 13 Mar 2023 17:36:33 +0000 Subject: [PATCH] libctf: fix a comment typo ctf_dedup's intern() function does not return a dynamically allocated string, so I just spent ten minutes auditing for obvious memory leaks that couldn't actually happen. Update the comment to note what it actually returns (a pointer into an atoms table: i.e. possibly not a new string, and not so easily leakable). libctf/ * ctf-dedup.c (intern): Update comment. --- libctf/ctf-dedup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libctf/ctf-dedup.c b/libctf/ctf-dedup.c index 6297c45c84d..5fdddfd0b54 100644 --- a/libctf/ctf-dedup.c +++ b/libctf/ctf-dedup.c @@ -412,7 +412,7 @@ intern (ctf_dict_t *fp, char *atom) /* Add an indication of the namespace to a type name in a way that is not valid for C identifiers. Used to maintain hashes of type names to other things while allowing for the four C namespaces (normal, struct, union, enum). - Return a new dynamically-allocated string. */ + Return a pointer into the cd_decorated_names atoms table. */ static const char * ctf_decorate_type_name (ctf_dict_t *fp, const char *name, int kind) { -- 2.30.2