From 05be85b649173b10d0bf10255eb15275c2dcf509 Mon Sep 17 00:00:00 2001 From: Marek Polacek Date: Mon, 4 May 2020 10:26:43 -0400 Subject: [PATCH] Revert "tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]" This reverts commit 6318fe77395fc0dd59419bc4d69cd06ac0158e54. Revert: 2020-04-30 Marek Polacek PR c++/94775 * tree.c (check_base_type): Return true only if TYPE_USER_ALIGN match. (check_aligned_type): Check if TYPE_USER_ALIGN match. --- gcc/ChangeLog | 9 +++++ gcc/testsuite/g++.dg/warn/Warray-bounds-10.C | 40 -------------------- gcc/tree.c | 4 +- 3 files changed, 10 insertions(+), 43 deletions(-) delete mode 100644 gcc/testsuite/g++.dg/warn/Warray-bounds-10.C diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 88a32acefc0..e6d102b1355 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,12 @@ +2020-05-04 Marek Polacek + + Revert: + 2020-04-30 Marek Polacek + + PR c++/94775 + * tree.c (check_base_type): Return true only if TYPE_USER_ALIGN match. + (check_aligned_type): Check if TYPE_USER_ALIGN match. + 2020-05-04 Richard Biener PR tree-optimization/93891 diff --git a/gcc/testsuite/g++.dg/warn/Warray-bounds-10.C b/gcc/testsuite/g++.dg/warn/Warray-bounds-10.C deleted file mode 100644 index 0a18f637e0e..00000000000 --- a/gcc/testsuite/g++.dg/warn/Warray-bounds-10.C +++ /dev/null @@ -1,40 +0,0 @@ -// PR c++/94775 -// { dg-do compile { target c++14 } } -// { dg-options "-O2 -Warray-bounds" } - -template using a = int; -template using b = int; -typedef char d; -template using e = int; -template struct h { using i = b>, e>; }; -template using j = typename h::i; -long ab, k, aj; -const d l[]{}; -class m { -public: - m(int); -}; -class n { - void ad() const; - template void o(long) const { - using c __attribute__((aligned(1))) = const ae; - } - long p; - template - auto s(unsigned long, unsigned long, unsigned long, unsigned long) const; - template auto q(unsigned long, unsigned long) const; -}; -template -auto n::s(unsigned long, unsigned long, unsigned long, unsigned long t) const { - o(p); - return t; -} -template auto n::q(unsigned long p1, unsigned long p2) const { - using r = j<4, false>; - using ai = j<4, g>; - return s(ab, k, p1, p2); -} -void n::ad() const { - long f(l[aj]); // { dg-warning "outside array bounds" } - m(q(8, f)); -} diff --git a/gcc/tree.c b/gcc/tree.c index 341766c51e5..e451401822c 100644 --- a/gcc/tree.c +++ b/gcc/tree.c @@ -6493,8 +6493,7 @@ check_base_type (const_tree cand, const_tree base) TYPE_ATTRIBUTES (base))) return false; /* Check alignment. */ - if (TYPE_ALIGN (cand) == TYPE_ALIGN (base) - && TYPE_USER_ALIGN (cand) == TYPE_USER_ALIGN (base)) + if (TYPE_ALIGN (cand) == TYPE_ALIGN (base)) return true; /* Atomic types increase minimal alignment. We must to do so as well or we get duplicated canonical types. See PR88686. */ @@ -6529,7 +6528,6 @@ check_aligned_type (const_tree cand, const_tree base, unsigned int align) && TYPE_CONTEXT (cand) == TYPE_CONTEXT (base) /* Check alignment. */ && TYPE_ALIGN (cand) == align - && TYPE_USER_ALIGN (cand) == TYPE_USER_ALIGN (base) && attribute_list_equal (TYPE_ATTRIBUTES (cand), TYPE_ATTRIBUTES (base)) && check_lang_type (cand, base)); -- 2.30.2