From 0602cdad745472ed2561d8096a4bb021c8d0301d Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Mon, 26 Jun 2017 13:25:41 +0100 Subject: [PATCH] Produce a consistent warning message when attempting to run a tool on a directory. PR binutils/21659 * bucomm.c (get_file_size): Explicitly warn if the file is a directory. --- binutils/ChangeLog | 6 ++++++ binutils/bucomm.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index cc4003cb4f5..6810c221547 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2017-06-26 Nick Clifton + + PR binutils/21659 + * bucomm.c (get_file_size): Explicitly warn if the file is a + directory. + 2017-06-24 Thomas Preud'homme * readelf.c (arm_attr_tag_CPU_arch): Fill value for ARMv8-R. diff --git a/binutils/bucomm.c b/binutils/bucomm.c index fd6f35604d8..5a0b634344c 100644 --- a/binutils/bucomm.c +++ b/binutils/bucomm.c @@ -598,6 +598,8 @@ get_file_size (const char * file_name) non_fatal (_("Warning: could not locate '%s'. reason: %s"), file_name, strerror (errno)); } + else if (S_ISDIR (statbuf.st_mode)) + non_fatal (_("Warning: '%s' is a directory"), file_name); else if (! S_ISREG (statbuf.st_mode)) non_fatal (_("Warning: '%s' is not an ordinary file"), file_name); else if (statbuf.st_size < 0) -- 2.30.2