From 0605df704d6f3c28c47bf6cd623bb237919e17a1 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Mon, 6 Mar 2023 11:45:12 +0000 Subject: [PATCH] gdb/gdbarch: remove yet more 'invalid=True' from gdbarch_components.py Following on from the previous commit, this commit removes yet more 'invalid=True' lines from gdbarch_components.py where the invalid setting has no effect. Due to the algorithm used in gdbarch.py for generated verify_gdbarch, if a component has a postdefault value then no invalid check will ever be generated for the component, as such setting 'invalid=True' on the component is pointless. This commit removes the setting of invalid. There is no change in the generated code after this commit. Approved-By: Simon Marchi --- gdb/gdbarch_components.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gdb/gdbarch_components.py b/gdb/gdbarch_components.py index 656c6a9f905..d3dfcfc806f 100644 --- a/gdb/gdbarch_components.py +++ b/gdb/gdbarch_components.py @@ -206,7 +206,6 @@ Value( type="const struct floatformat **", name="bfloat16_format", postdefault="floatformats_bfloat16", - invalid=True, printer="pformat (gdbarch, gdbarch->bfloat16_format)", ) @@ -221,7 +220,6 @@ Value( type="const struct floatformat **", name="half_format", postdefault="floatformats_ieee_half", - invalid=True, printer="pformat (gdbarch, gdbarch->half_format)", ) @@ -236,7 +234,6 @@ Value( type="const struct floatformat **", name="float_format", postdefault="floatformats_ieee_single", - invalid=True, printer="pformat (gdbarch, gdbarch->float_format)", ) @@ -251,7 +248,6 @@ Value( type="const struct floatformat **", name="double_format", postdefault="floatformats_ieee_double", - invalid=True, printer="pformat (gdbarch, gdbarch->double_format)", ) @@ -266,7 +262,6 @@ Value( type="const struct floatformat **", name="long_double_format", postdefault="floatformats_ieee_double", - invalid=True, printer="pformat (gdbarch, gdbarch->long_double_format)", ) @@ -289,7 +284,6 @@ One if `wchar_t' is signed, zero if unsigned. name="wchar_signed", predefault="-1", postdefault="1", - invalid=True, ) Method( @@ -332,7 +326,6 @@ addr_bit is the size of a target address as represented in gdb name="addr_bit", predefault="0", postdefault="gdbarch_ptr_bit (gdbarch)", - invalid=True, ) Value( @@ -355,7 +348,6 @@ and if Dwarf versions < 4 need to be supported. name="dwarf2_addr_size", predefault="0", postdefault="gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT", - invalid=True, ) Value( @@ -366,7 +358,6 @@ One if `char' acts like `signed char', zero if `unsigned char'. name="char_signed", predefault="-1", postdefault="1", - invalid=True, ) Function( -- 2.30.2