From 065525e3a71a7750888b55675a6ee58eb8fdb309 Mon Sep 17 00:00:00 2001 From: Jim Kingdon Date: Thu, 26 Aug 1993 15:37:03 +0000 Subject: [PATCH] add comments re stub types --- gdb/gdbtypes.c | 4 ++++ gdb/gdbtypes.h | 6 ++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index bc7e2576ac5..b2d004707df 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -805,6 +805,10 @@ check_stub_type (type) if (TYPE_FLAGS(type) & TYPE_FLAG_STUB) { char* name = type_name_no_tag (type); + /* FIXME: shouldn't we separately check the TYPE_NAME and the + TYPE_TAG_NAME, and look in STRUCT_NAMESPACE and/or VAR_NAMESPACE + as appropriate? (this code was written before TYPE_NAME and + TYPE_TAG_NAME were separate). */ struct symbol *sym; if (name == NULL) { diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 8ccf37af99d..77d2cb87bf3 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -122,7 +122,7 @@ enum type_code #define TYPE_FLAG_SIGNED (1 << 1) -/* This appears in a type's flags word if it is a stub type (eg. if +/* This appears in a type's flags word if it is a stub type (e.g., if someone referenced a type that wasn't defined in a source file via (struct sir_not_appearing_in_this_film *)). */ @@ -150,7 +150,9 @@ struct type with this feature. This is used for printing only, except by poorly designed C++ code. - For looking up a name, look for a symbol in the STRUCT_NAMESPACE. */ + For looking up a name, look for a symbol in the STRUCT_NAMESPACE. + One more legitimate use is that if TYPE_FLAG_STUB is set, this is + the name to use to look for definitions in other files. */ char *tag_name; -- 2.30.2