From 0658b53e9303afaf552604ab2a6e56e363efcf5c Mon Sep 17 00:00:00 2001 From: "Daniel R. Carvalho" Date: Tue, 16 Jun 2020 17:15:32 +0200 Subject: [PATCH] mem-cache: Fix RepeatedQwords compressor This compressor does not allocate dictionary entries when there is a match. This was causing the compressor to always fail. Change-Id: I50eb56fa284854f3ee87f33af2c6e0a5c5248d7c Signed-off-by: Daniel R. Carvalho Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33375 Reviewed-by: Nikos Nikoleris Maintainer: Nikos Nikoleris Tested-by: kokoro --- src/mem/cache/compressors/dictionary_compressor.hh | 5 +++-- src/mem/cache/compressors/repeated_qwords.hh | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mem/cache/compressors/dictionary_compressor.hh b/src/mem/cache/compressors/dictionary_compressor.hh index 650edab5a..b9c68a1d6 100644 --- a/src/mem/cache/compressors/dictionary_compressor.hh +++ b/src/mem/cache/compressors/dictionary_compressor.hh @@ -563,9 +563,10 @@ class DictionaryCompressor::LocatedMaskedPattern const uint64_t code, const uint64_t metadata_length, const int match_location, - const DictionaryEntry bytes) + const DictionaryEntry bytes, + const bool allocate = true) : MaskedPattern(number, code, metadata_length, match_location, - bytes) + bytes, allocate) { } diff --git a/src/mem/cache/compressors/repeated_qwords.hh b/src/mem/cache/compressors/repeated_qwords.hh index c361900c9..9a2df3caa 100644 --- a/src/mem/cache/compressors/repeated_qwords.hh +++ b/src/mem/cache/compressors/repeated_qwords.hh @@ -116,7 +116,7 @@ class RepeatedQwords::PatternM public: PatternM(const DictionaryEntry bytes, const int match_location) : LocatedMaskedPattern<0xFFFFFFFFFFFFFFFF, 0>(M, 1, 0, match_location, - bytes) + bytes, false) { } }; -- 2.30.2