From 074084767c9d7c4d52d919c343b65bb61c564096 Mon Sep 17 00:00:00 2001 From: Richard Sandiford Date: Mon, 29 Apr 2019 15:17:01 +0000 Subject: [PATCH] Remove DDR_INNER_LOOP ...since it was only ever zero in practice. I wondered about making it a symbolic constant instead, but it didn't seem worth it when there was only one user (and that user was part of the internal tree-data-ref.c implementation). 2019-04-29 Richard Sandiford gcc/ * tree-data-ref.h (data_dependence_relation::inner_loop): Delete. (DDR_INNER_LOOP): Likewise. * tree-data-ref.c (dump_data_dependence_relation): Update accordingly. (initialize_data_dependence_relation): Likewise. (insert_innermost_unit_dist_vector): Use 0 instead of DDR_INNER_LOOP. From-SVN: r270654 --- gcc/ChangeLog | 8 ++++++++ gcc/tree-data-ref.c | 4 +--- gcc/tree-data-ref.h | 5 ----- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 0c2b51a4681..e548281a86d 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2019-04-29 Richard Sandiford + + * tree-data-ref.h (data_dependence_relation::inner_loop): Delete. + (DDR_INNER_LOOP): Likewise. + * tree-data-ref.c (dump_data_dependence_relation): Update accordingly. + (initialize_data_dependence_relation): Likewise. + (insert_innermost_unit_dist_vector): Use 0 instead of DDR_INNER_LOOP. + 2019-04-29 Jakub Jelinek PR rtl-optimization/90257 diff --git a/gcc/tree-data-ref.c b/gcc/tree-data-ref.c index ccb1cfc5369..6c69f77e653 100644 --- a/gcc/tree-data-ref.c +++ b/gcc/tree-data-ref.c @@ -460,7 +460,6 @@ dump_data_dependence_relation (FILE *outf, dump_subscript (outf, sub); } - fprintf (outf, " inner loop index: %d\n", DDR_INNER_LOOP (ddr)); fprintf (outf, " loop nest: ("); FOR_EACH_VEC_ELT (DDR_LOOP_NEST (ddr), i, loopi) fprintf (outf, "%d ", loopi->num); @@ -2643,7 +2642,6 @@ initialize_data_dependence_relation (struct data_reference *a, DDR_ARE_DEPENDENT (res) = NULL_TREE; DDR_SUBSCRIPTS (res).create (full_seq.length); DDR_LOOP_NEST (res) = loop_nest; - DDR_INNER_LOOP (res) = 0; DDR_SELF_REFERENCE (res) = false; for (i = 0; i < full_seq.length; ++i) @@ -4478,7 +4476,7 @@ insert_innermost_unit_dist_vector (struct data_dependence_relation *ddr) { lambda_vector dist_v = lambda_vector_new (DDR_NB_LOOPS (ddr)); - dist_v[DDR_INNER_LOOP (ddr)] = 1; + dist_v[0] = 1; save_dist_v (ddr, dist_v); } diff --git a/gcc/tree-data-ref.h b/gcc/tree-data-ref.h index 2a5082db398..ab44d072731 100644 --- a/gcc/tree-data-ref.h +++ b/gcc/tree-data-ref.h @@ -347,10 +347,6 @@ struct data_dependence_relation /* The classic distance vector. */ vec dist_vects; - /* An index in loop_nest for the innermost loop that varies for - this data dependence relation. */ - unsigned inner_loop; - /* Is the dependence reversed with respect to the lexicographic order? */ bool reversed_p; @@ -406,7 +402,6 @@ typedef struct data_dependence_relation *ddr_p; /* The size of the direction/distance vectors: the number of loops in the loop nest. */ #define DDR_NB_LOOPS(DDR) (DDR_LOOP_NEST (DDR).length ()) -#define DDR_INNER_LOOP(DDR) (DDR)->inner_loop #define DDR_SELF_REFERENCE(DDR) (DDR)->self_reference_p #define DDR_DIST_VECTS(DDR) ((DDR)->dist_vects) -- 2.30.2