From 078b5aab3875630d6b09cac4ea4408ef9ba04a00 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Tue, 4 Oct 2016 13:40:54 +0000 Subject: [PATCH] re PR tree-optimization/77399 (Poor code generation for vector casts and loads) 2016-10-04 Richard Biener PR tree-optimization/77399 * tree-ssa-forwprop.c (simplify_vector_constructor): Properly verify the target can convert. * gcc.dg/tree-ssa/forwprop-35.c: Adjust. From-SVN: r240744 --- gcc/ChangeLog | 6 ++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/tree-ssa/forwprop-35.c | 5 +++-- gcc/tree-ssa-forwprop.c | 8 ++++++++ 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6e0de29444e..e91ec1b349e 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2016-10-04 Richard Biener + + PR tree-optimization/77399 + * tree-ssa-forwprop.c (simplify_vector_constructor): Properly + verify the target can convert. + 2016-10-04 Richard Biener PR middle-end/77833 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 9a8692eacf3..c6b9d87c5ab 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-10-04 Richard Biener + + PR tree-optimization/77399 + * gcc.dg/tree-ssa/forwprop-35.c: Adjust. + 2016-10-04 Richard Biener PR middle-end/77833 diff --git a/gcc/testsuite/gcc.dg/tree-ssa/forwprop-35.c b/gcc/testsuite/gcc.dg/tree-ssa/forwprop-35.c index 24a1ad9c767..79053a285d1 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/forwprop-35.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/forwprop-35.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-O -fdump-tree-cddce1" } */ +/* { dg-additional-options "-msse2" { target { i?86-*-* x86_64-*-* } } } */ typedef int v4si __attribute__((vector_size(16))); typedef float v4sf __attribute__((vector_size(16))); @@ -14,5 +15,5 @@ v4sf vec_cast_perm(v4si f) return (v4sf){f[1], f[1], f[2], f[3]}; } -/* { dg-final { scan-tree-dump-times "VEC_PERM_EXPR" 1 "cddce1" } } */ -/* { dg-final { scan-tree-dump-times "\\\(v4sf\\\) " 2 "cddce1" } } */ +/* { dg-final { scan-tree-dump-times "VEC_PERM_EXPR" 1 "cddce1" { target { i?86-*-* x86_64-*-* } } } } */ +/* { dg-final { scan-tree-dump-times "\\\(v4sf\\\) " 2 "cddce1" { target { i?86-*-* x86_64-*-* } } } } */ diff --git a/gcc/tree-ssa-forwprop.c b/gcc/tree-ssa-forwprop.c index cd066ef0587..ed11b32fbfe 100644 --- a/gcc/tree-ssa-forwprop.c +++ b/gcc/tree-ssa-forwprop.c @@ -45,6 +45,7 @@ along with GCC; see the file COPYING3. If not see #include "builtins.h" #include "tree-cfgcleanup.h" #include "cfganal.h" +#include "optabs-tree.h" /* This pass propagates the RHS of assignment statements into use sites of the LHS of the assignment. It's basically a specialized @@ -2037,6 +2038,13 @@ simplify_vector_constructor (gimple_stmt_iterator *gsi) != TYPE_VECTOR_SUBPARTS (TREE_TYPE (orig)))) return false; + tree tem; + if (conv_code != ERROR_MARK + && (! supportable_convert_operation (conv_code, type, TREE_TYPE (orig), + &tem, &conv_code) + || conv_code == CALL_EXPR)) + return false; + if (maybe_ident) { if (conv_code == ERROR_MARK) -- 2.30.2