From 07b9f1de1ea532a66d8ac103f3a9827521d780f9 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Tue, 20 Nov 2018 08:06:09 +0000 Subject: [PATCH] re PR lto/88087 (ICE in execute at tree-ssa-pre.c:4220 since r266183) 2018-11-20 Richard Biener PR tree-optimization/88087 * tree-ssa-pre.c (create_expression_by_pieces): Re-materialize call fntype. * tree-ssa-sccvn.c (copy_reference_ops_from_call): Remember call fntype. * gcc.dg/tree-ssa/pr88087.c: New testcase. From-SVN: r266301 --- gcc/ChangeLog | 8 ++++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/tree-ssa/pr88087.c | 17 +++++++++++++++++ gcc/tree-ssa-pre.c | 3 ++- gcc/tree-ssa-sccvn.c | 2 +- 5 files changed, 33 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/pr88087.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 712146fccb6..0c357fb4bed 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2018-11-20 Richard Biener + + PR tree-optimization/88087 + * tree-ssa-pre.c (create_expression_by_pieces): Re-materialize + call fntype. + * tree-ssa-sccvn.c (copy_reference_ops_from_call): Remember + call fntype. + 2018-11-20 Richard Biener PR middle-end/88089 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 29e67449752..4284ce25dab 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-11-20 Richard Biener + + PR tree-optimization/88087 + * gcc.dg/tree-ssa/pr88087.c: New testcase. + 2018-11-19 Paul Koning * gcc.c-torture/execute/align-3.c: Skip if pdp11. diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr88087.c b/gcc/testsuite/gcc.dg/tree-ssa/pr88087.c new file mode 100644 index 00000000000..d0061b61aed --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr88087.c @@ -0,0 +1,17 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-pre-stats" } */ + +int f(); +int d; +void c() +{ + for (;;) + { + f(); + int (*fp)() __attribute__((const)) = (void *)f; + d = fp(); + } +} + +/* We shouldn't ICE and hoist the const call of fp out of the loop. */ +/* { dg-final { scan-tree-dump "Eliminated: 1" "pre" } } */ diff --git a/gcc/tree-ssa-pre.c b/gcc/tree-ssa-pre.c index 20d3c7807a1..4d5bce83a2c 100644 --- a/gcc/tree-ssa-pre.c +++ b/gcc/tree-ssa-pre.c @@ -2792,9 +2792,10 @@ create_expression_by_pieces (basic_block block, pre_expr expr, args.quick_push (arg); } gcall *call = gimple_build_call_vec (fn, args); + gimple_call_set_fntype (call, currop->type); if (sc) gimple_call_set_chain (call, sc); - tree forcedname = make_ssa_name (currop->type); + tree forcedname = make_ssa_name (TREE_TYPE (currop->type)); gimple_call_set_lhs (call, forcedname); /* There's no CCP pass after PRE which would re-compute alignment information so make sure we re-materialize this here. */ diff --git a/gcc/tree-ssa-sccvn.c b/gcc/tree-ssa-sccvn.c index 43641916d52..01bedf56662 100644 --- a/gcc/tree-ssa-sccvn.c +++ b/gcc/tree-ssa-sccvn.c @@ -1206,7 +1206,7 @@ copy_reference_ops_from_call (gcall *call, /* Copy the type, opcode, function, static chain and EH region, if any. */ memset (&temp, 0, sizeof (temp)); - temp.type = gimple_call_return_type (call); + temp.type = gimple_call_fntype (call); temp.opcode = CALL_EXPR; temp.op0 = gimple_call_fn (call); temp.op1 = gimple_call_chain (call); -- 2.30.2