From 08ce1d723ea3360a8ae52a4a4bd395ec984563eb Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Fri, 24 Jun 2016 12:16:24 -0400 Subject: [PATCH] fix undefined reference to bfd_link_plugin_object_p during link When configured with the default options, GDB currently fails to link, due to an undefined reference to bfd_link_plugin_object_p, coming from elflink.c: #ifdef BFD_SUPPORTS_PLUGINS || (abfd->plugin_format == bfd_plugin_unknown && bfd_link_plugin_object_p (abfd)) #endif This is because BFD_SUPPORTS_PLUGINS is always defined. It is its value that determines whether plugin support is enabled or not. bfd/ChangeLog: * elflink.c: Check the value of BFD_SUPPORTS_PLUGINS rather than its existance. --- bfd/elflink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bfd/elflink.c b/bfd/elflink.c index bb83854a275..ad8493b3a90 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -28,7 +28,7 @@ #include "safe-ctype.h" #include "libiberty.h" #include "objalloc.h" -#ifdef BFD_SUPPORTS_PLUGINS +#if BFD_SUPPORTS_PLUGINS #include "plugin.h" #endif @@ -3134,7 +3134,7 @@ elf_link_is_defined_archive_symbol (bfd * abfd, carsym * symdef) object file is an IR object, give linker LTO plugin a chance to get the correct symbol table. */ if (abfd->plugin_format == bfd_plugin_yes -#ifdef BFD_SUPPORTS_PLUGINS +#if BFD_SUPPORTS_PLUGINS || (abfd->plugin_format == bfd_plugin_unknown && bfd_link_plugin_object_p (abfd)) #endif -- 2.30.2