From 0a2dcd3a8ac4bf18cd6ec2f778c9ef859ef90a51 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tapani=20P=C3=A4lli?= Date: Thu, 2 Feb 2017 14:05:46 +0200 Subject: [PATCH] android: fix droid_create_image_from_prime_fd_yuv for YV12 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Earlier changes introduced is_ycrcb flag which checks the component order of u and v components. Condition for setting the flag was incorrect, with ycrcb we are supposed to have cr before cb. This patch (together with a fix in our gralloc) fixes corrupted rendering from 'test-opengl-gl2_yuvtex' native test and corrupted gallery thumbnail in application switcher on Android-IA. Fixes: 51727b1cf57e8c4630767eb9ead207b102ffa489 Signed-off-by: Tapani Pälli Reviewed-by: Plamena Manolova Reviewed-by: Marta Lofstedt Reviewed-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 36bd119e501..511b696192a 100644 --- a/src/egl/drivers/dri2/platform_android.c +++ b/src/egl/drivers/dri2/platform_android.c @@ -629,7 +629,7 @@ droid_create_image_from_prime_fd_yuv(_EGLDisplay *disp, _EGLContext *ctx, * so they can be interpreted as offsets. */ offsets[0] = (size_t)ycbcr.y; /* We assume here that all the planes are located in one DMA-buf. */ - is_ycrcb = (size_t)ycbcr.cb < (size_t)ycbcr.cr; + is_ycrcb = (size_t)ycbcr.cr < (size_t)ycbcr.cb; if (is_ycrcb) { offsets[1] = (size_t)ycbcr.cr; offsets[2] = (size_t)ycbcr.cb; -- 2.30.2