From 0a89784bcc988d602bbe8b310aca8c54ef03d954 Mon Sep 17 00:00:00 2001 From: Andres Rodriguez Date: Thu, 21 Dec 2017 19:18:59 -0500 Subject: [PATCH] mesa: check for invalid index on UUID glGet queries MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This fixes the piglit test: spec/ext_semaphore/api-errors/usigned-byte-i-v-bad-value Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/mesa/main/get.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 1e4b8f6f0bc..cf9a2f66d2f 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -2578,9 +2578,13 @@ find_value_indexed(const char *func, GLenum pname, GLuint index, union value *v) v->value_int = 1; return TYPE_INT; case GL_DRIVER_UUID_EXT: + if (index >= 1) + goto invalid_value; _mesa_get_driver_uuid(ctx, v->value_int_4); return TYPE_INT_4; case GL_DEVICE_UUID_EXT: + if (index >= 1) + goto invalid_value; _mesa_get_device_uuid(ctx, v->value_int_4); return TYPE_INT_4; } -- 2.30.2