From 0a899fd5acf97c0c9af7c6548e2c0e132148cf78 Mon Sep 17 00:00:00 2001 From: DJ Delorie Date: Wed, 2 Apr 2014 16:50:29 -0400 Subject: [PATCH] Add checks for overfar branches Check 8 and 16 bit PCREL fixes for overflow, since we bypass the later overflow checks in write.c. Direct relocs are left alone, as gcc has been known to take advantage of the silent overflows when comparing addresses to constant ranges. --- gas/ChangeLog | 5 +++++ gas/config/tc-rl78.c | 14 ++++++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index c6b2bb543a0..c7adc4cc2b4 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2014-04-02 DJ Delorie + + * config/tc-rl78.c (md_apply_fix): Add overflow warnings for + pc-relative branches. + 2014-04-02 Nick Clifton PR gas/16765 diff --git a/gas/config/tc-rl78.c b/gas/config/tc-rl78.c index ae8f5af8d19..bbbf47bb400 100644 --- a/gas/config/tc-rl78.c +++ b/gas/config/tc-rl78.c @@ -1310,13 +1310,23 @@ md_apply_fix (struct fix * f ATTRIBUTE_UNUSED, f->fx_done = 1; break; - case BFD_RELOC_8: case BFD_RELOC_8_PCREL: + if ((long)val < -128 || (long)val > 127) + as_bad_where (f->fx_file, f->fx_line, + _("value of %ld too large for 8-bit branch"), + val); + /* Fall through. */ + case BFD_RELOC_8: op[0] = val; break; - case BFD_RELOC_16: case BFD_RELOC_16_PCREL: + if ((long)val < -32768 || (long)val > 32767) + as_bad_where (f->fx_file, f->fx_line, + _("value of %ld too large for 16-bit branch"), + val); + /* Fall through. */ + case BFD_RELOC_16: case BFD_RELOC_RL78_CODE: op[0] = val; op[1] = val >> 8; -- 2.30.2