From 0aa359c18fe4b3373bae59b3c7e414dbe027c19b Mon Sep 17 00:00:00 2001 From: Paolo Carlini Date: Wed, 29 Apr 2015 14:06:27 +0000 Subject: [PATCH] re PR c++/64667 (-Winit-self ignored for reference fields) /cp 2015-04-29 Paolo Carlini PR c++/64667 * init.c (perform_member_init): Handle references for -Winit-self. /testsuite 2015-04-29 Paolo Carlini PR c++/64667 * g++.dg/warn/Winit-self-3.C: New. From-SVN: r222577 --- gcc/cp/ChangeLog | 5 +++++ gcc/cp/init.c | 3 +++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/warn/Winit-self-3.C | 26 ++++++++++++++++++++++++ 4 files changed, 39 insertions(+) create mode 100644 gcc/testsuite/g++.dg/warn/Winit-self-3.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index cc716b86160..3ee050ce753 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2015-04-29 Paolo Carlini + + PR c++/64667 + * init.c (perform_member_init): Handle references for -Winit-self. + 2015-04-29 Thomas Schwinge * pt.c (tsubst_expr) : Use diff --git a/gcc/cp/init.c b/gcc/cp/init.c index 957a7a4e6e8..a4fc9ff33cd 100644 --- a/gcc/cp/init.c +++ b/gcc/cp/init.c @@ -625,6 +625,9 @@ perform_member_init (tree member, tree init) && TREE_CHAIN (init) == NULL_TREE) { tree val = TREE_VALUE (init); + /* Handle references. */ + if (REFERENCE_REF_P (val)) + val = TREE_OPERAND (val, 0); if (TREE_CODE (val) == COMPONENT_REF && TREE_OPERAND (val, 1) == member && TREE_OPERAND (val, 0) == current_class_ref) warning_at (DECL_SOURCE_LOCATION (current_function_decl), diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 3ec76730548..df61b1c15b9 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-04-29 Paolo Carlini + + PR c++/64667 + * g++.dg/warn/Winit-self-3.C: New. + 2015-04-29 Uros Bizjak * gfortran.dg/namelist_87.f90: Use dg-add-options ieee. diff --git a/gcc/testsuite/g++.dg/warn/Winit-self-3.C b/gcc/testsuite/g++.dg/warn/Winit-self-3.C new file mode 100644 index 00000000000..dd06ad017e9 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Winit-self-3.C @@ -0,0 +1,26 @@ +// PR c++/64667 +// { dg-options "-Winit-self" } + +class A +{ +public: + A(const A&) : a(a) {} // { dg-warning "initialized with itself" } +private: + int a; +}; + +class B +{ +public: + B(const B&) : b(b) {} // { dg-warning "initialized with itself" } +private: + int* b; +}; + +class C +{ +public: + C(const C&) : c(c) {} // { dg-warning "initialized with itself" } +private: + int& c; +}; -- 2.30.2