From 0dedf3777db42712f460123ac0c63c49de5456f5 Mon Sep 17 00:00:00 2001 From: Thomas Preud'homme Date: Thu, 6 Apr 2017 17:17:23 +0100 Subject: [PATCH] Fix Windows gdb build failure with Python 2 support GDB fails to build for Windows host with Python 2 support enabled due to PyFile_FromString's second argument being of type char * and being passed a (const) string literal. This parameter is input only so this commit fixes the issue by casting to char *. 2017-04-06 Thomas Preud'homme gdb/ * python/python.c (python_run_simple_file): Cast mode literal to non-const char pointer as expected by PyFile_FromString. --- gdb/ChangeLog | 5 +++++ gdb/python/python.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 880af5b8c93..e906b870c5c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-04-06 Thomas Preud'homme + + * python/python.c (python_run_simple_file): Cast mode literal to + non-const char pointer as expected by PyFile_FromString. + 2017-04-05 Simon Marchi * common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with diff --git a/gdb/python/python.c b/gdb/python/python.c index cc58267b955..e0e24acac41 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -352,7 +352,7 @@ python_run_simple_file (FILE *file, const char *filename) /* Because we have a string for a filename, and are using Python to open the file, we need to expand any tilde in the path first. */ gdb::unique_xmalloc_ptr full_path (tilde_expand (filename)); - gdbpy_ref<> python_file (PyFile_FromString (full_path.get (), "r")); + gdbpy_ref<> python_file (PyFile_FromString (full_path.get (), (char *) "r")); if (python_file == NULL) { gdbpy_print_stack (); -- 2.30.2