From 0e30a3b0f233f828cc3274c2131ed31db275629c Mon Sep 17 00:00:00 2001 From: John Baldwin Date: Thu, 17 Mar 2022 09:37:24 -0700 Subject: [PATCH] Remove fall throughs in core_target::xfer_partial. The cases for TARGET_OBJECT_LIBRARIES and TARGET_OBJECT_LIBRARIES_AIX can try to fetch different data objects (such as TARGET_OBJECT_SIGNAL_INFO) if gdbarch methods for the requested data aren't present. Return with TARGET_XFER_E_IO if the gdbarch method isn't present instead. --- gdb/corelow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index 1579e6bc2b8..001c4f147fc 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -943,7 +943,7 @@ core_target::xfer_partial (enum target_object object, const char *annex, return TARGET_XFER_OK; } } - /* FALL THROUGH */ + return TARGET_XFER_E_IO; case TARGET_OBJECT_LIBRARIES_AIX: if (m_core_gdbarch != nullptr @@ -964,7 +964,7 @@ core_target::xfer_partial (enum target_object object, const char *annex, return TARGET_XFER_OK; } } - /* FALL THROUGH */ + return TARGET_XFER_E_IO; case TARGET_OBJECT_SIGNAL_INFO: if (readbuf) -- 2.30.2