From 0f5cb49f68ae1be4b9702e71c3a9b80ee46b310a Mon Sep 17 00:00:00 2001 From: YunQiang Su Date: Fri, 30 Jun 2023 14:07:57 +0800 Subject: [PATCH] ld: Use run_host_cmd_yesno in indirect.exp instead of catch exec Catch "exec $CC_FOR_TARGET" won't use the gas/ld that we just build, and in fact run_host_cmd_yesno is a better choice for it. ld/ChangeLog: * testsuite/ld-elf/indirect.exp: use run_host_cmd_yesno instead of handwrite catch exec $CC_FOR_TARGET. --- ld/testsuite/ld-elf/indirect.exp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ld/testsuite/ld-elf/indirect.exp b/ld/testsuite/ld-elf/indirect.exp index eda48d30949..de5d9714e19 100644 --- a/ld/testsuite/ld-elf/indirect.exp +++ b/ld/testsuite/ld-elf/indirect.exp @@ -226,10 +226,7 @@ foreach t [list indirect5a indirect5b indirect6a indirect6b] { } } -send_log "$CC_FOR_TARGET -fPIE -pie $srcdir/$subdir/main.c -o tmpdir/pie" -catch "exec $CC_FOR_TARGET -fPIE -pie $srcdir/$subdir/main.c -o tmpdir/pie" exec_output -send_log "$exec_output" -if { ! [string match "" $exec_output] } { +if { ![run_host_cmd_yesno $CC_FOR_TARGET "-fPIC -pie $srcdir/$subdir/main.c -o tmpdir/pie"] } { return } -- 2.30.2