From 0f977b7715ee9aa8959e08c00b6d2c47a40e6504 Mon Sep 17 00:00:00 2001 From: Kevin Buettner Date: Thu, 25 Feb 2021 15:25:49 -0700 Subject: [PATCH] Add comment regarding include order of and I added the same comment for nat/aarch64-linux-hw-point.c yesterday. Christian suggested adding the comment for the other file that I had identified as including both and . I searched the sources in gdb/, but found no other files which include both of these headers. If possible, I would prefer to see us use when possible, however, from past experience, I've found that this file does not always contain all of the constants, etc. required by the particular source file. gdb/ChangeLog: * nat/aarch64-sve-linux-ptrace.h: Add comment regarding include order for and . --- gdb/ChangeLog | 5 +++++ gdb/nat/aarch64-sve-linux-ptrace.h | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 842dc0a1374..7e0b00cc7c6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2021-02-24 Kevin Buettner + + * nat/aarch64-sve-linux-ptrace.h: Add comment regarding + include order for and . + 2021-02-25 Simon Marchi PR gdb/26861 diff --git a/gdb/nat/aarch64-sve-linux-ptrace.h b/gdb/nat/aarch64-sve-linux-ptrace.h index 06684023f5d..be00f306137 100644 --- a/gdb/nat/aarch64-sve-linux-ptrace.h +++ b/gdb/nat/aarch64-sve-linux-ptrace.h @@ -22,6 +22,12 @@ #include #include + +/* The order in which and are included + can be important. often declares various PTRACE_* + enums. often defines preprocessor constants for + these very same symbols. When that's the case, build errors will + result when is included before . */ #include #include -- 2.30.2