From 0f9eeae878ce11035d027722eddf28654b6cfeb7 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Sun, 25 May 2014 01:08:54 -0700 Subject: [PATCH] i965/sf: Drop unnecessary push/pop in flatshading code. brw_JMPI sets predicate_control to BRW_PREDICATE_NONE, but that's already the value coming in. Otherwise, nothing changes state. Signed-off-by: Kenneth Graunke Reviewed-by: Matt Turner --- src/mesa/drivers/dri/i965/brw_sf_emit.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_sf_emit.c b/src/mesa/drivers/dri/i965/brw_sf_emit.c index 45e6767b2c7..501453681ff 100644 --- a/src/mesa/drivers/dri/i965/brw_sf_emit.c +++ b/src/mesa/drivers/dri/i965/brw_sf_emit.c @@ -207,8 +207,6 @@ static void do_flatshade_triangle( struct brw_sf_compile *c ) nr = count_flatshaded_attributes(c); - brw_push_insn_state(p); - brw_MUL(p, c->pv, c->pv, brw_imm_d(jmpi*(nr*2+1))); brw_JMPI(p, ip, ip, c->pv); @@ -222,8 +220,6 @@ static void do_flatshade_triangle( struct brw_sf_compile *c ) copy_flatshaded_attributes(c, c->vert[0], c->vert[2]); copy_flatshaded_attributes(c, c->vert[1], c->vert[2]); - - brw_pop_insn_state(p); } @@ -245,16 +241,12 @@ static void do_flatshade_line( struct brw_sf_compile *c ) nr = count_flatshaded_attributes(c); - brw_push_insn_state(p); - brw_MUL(p, c->pv, c->pv, brw_imm_d(jmpi*(nr+1))); brw_JMPI(p, ip, ip, c->pv); copy_flatshaded_attributes(c, c->vert[1], c->vert[0]); brw_JMPI(p, ip, ip, brw_imm_ud(jmpi*nr)); copy_flatshaded_attributes(c, c->vert[0], c->vert[1]); - - brw_pop_insn_state(p); } -- 2.30.2