From 0fac5f2a7f15974deabf6432f4f510d0f4bcc6bc Mon Sep 17 00:00:00 2001 From: Prathamesh Kulkarni Date: Tue, 15 May 2018 04:44:33 +0000 Subject: [PATCH] re PR ipa/85734 (--suggest-attribute=malloc misdiagnoses static functions) 2018-05-15 Prathamesh Kulkarni PR ipa/85734 * ipa-pure-const.c (warn_function_malloc): Pass value of known_finite param as true in call to suggest_attribute. testsuite/ * gcc.dg/ipa/pr85734.c: New test. From-SVN: r260249 --- gcc/ChangeLog | 6 ++++++ gcc/ipa-pure-const.c | 2 +- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/ipa/pr85734.c | 19 +++++++++++++++++++ 4 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/ipa/pr85734.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9e54758cf09..294a937327a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2018-05-15 Prathamesh Kulkarni + + PR ipa/85734 + * ipa-pure-const.c (warn_function_malloc): Pass value of known_finite param + as true in call to suggest_attribute. + 2018-05-14 Segher Boessenkool * doc/invoke.texi (RS/6000 and PowerPC Options): Delete @itemx for diff --git a/gcc/ipa-pure-const.c b/gcc/ipa-pure-const.c index a80b6845633..7665358a9a5 100644 --- a/gcc/ipa-pure-const.c +++ b/gcc/ipa-pure-const.c @@ -249,7 +249,7 @@ warn_function_malloc (tree decl) static hash_set *warned_about; warned_about = suggest_attribute (OPT_Wsuggest_attribute_malloc, decl, - false, warned_about, "malloc"); + true, warned_about, "malloc"); } /* Emit suggestion about __attribute__((noreturn)) for DECL. */ diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 4a0b371cecc..452e6a276a5 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-05-14 Prathamesh Kulkarni + + PR ipa/85734 + * gcc.dg/ipa/pr85734.c: New test. + 2018-05-14 Eric Botcazou PR target/85756 diff --git a/gcc/testsuite/gcc.dg/ipa/pr85734.c b/gcc/testsuite/gcc.dg/ipa/pr85734.c new file mode 100644 index 00000000000..e5fa21f0548 --- /dev/null +++ b/gcc/testsuite/gcc.dg/ipa/pr85734.c @@ -0,0 +1,19 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -Wsuggest-attribute=malloc" } */ + +__attribute__((noinline)) +static void *f1(__SIZE_TYPE__ sz) /* { dg-bogus "function might be candidate for attribute 'malloc'" } */ +{ + return __builtin_malloc (sz); +} + +__attribute__((noinline)) +static void *f2(__SIZE_TYPE__ sz) /* { dg-bogus "function might be candidate for attribute 'malloc'" } */ +{ + return f1 (sz); +} + +void *f3(__SIZE_TYPE__ sz) /* { dg-warning "function might be candidate for attribute 'malloc'" } */ +{ + return f2(sz); +} -- 2.30.2