From 0fed74615b0f263c359a13a7a17ade36a986ddd1 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 24 Dec 2021 22:11:06 -0700 Subject: [PATCH] Send jit.c errors to gdb_stderr jit.c writes some error messages to gdb_stdout, but using gdb_stderr is better. This is part of PR gdb/7233. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=7233 --- gdb/jit.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/gdb/jit.c b/gdb/jit.c index e190e695aa8..477183f3e4b 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -251,8 +251,8 @@ jit_read_descriptor (gdbarch *gdbarch, err = target_read_memory (addr, desc_buf, desc_size); if (err) { - printf_unfiltered (_("Unable to read JIT descriptor from " - "remote memory\n")); + fprintf_unfiltered (gdb_stderr, _("Unable to read JIT descriptor from " + "remote memory\n")); return false; } @@ -719,7 +719,8 @@ jit_bfd_try_read_symtab (struct jit_code_entry *code_entry, (code_entry->symfile_addr, code_entry->symfile_size, gnutarget)); if (nbfd == NULL) { - puts_unfiltered (_("Error opening JITed symbol file, ignoring it.\n")); + fputs_unfiltered (_("Error opening JITed symbol file, ignoring it.\n"), + gdb_stderr); return; } @@ -727,7 +728,7 @@ jit_bfd_try_read_symtab (struct jit_code_entry *code_entry, We would segfault later without this line. */ if (!bfd_check_format (nbfd.get (), bfd_object)) { - printf_unfiltered (_("\ + fprintf_unfiltered (gdb_stderr, _("\ JITed symbol file is not an object file, ignoring it.\n")); return; } @@ -1138,9 +1139,10 @@ jit_inferior_init (inferior *inf) /* Check that the version number agrees with that we support. */ if (descriptor.version != 1) { - printf_unfiltered (_("Unsupported JIT protocol version %ld " - "in descriptor (expected 1)\n"), - (long) descriptor.version); + fprintf_unfiltered (gdb_stderr, + _("Unsupported JIT protocol version %ld " + "in descriptor (expected 1)\n"), + (long) descriptor.version); continue; } @@ -1229,9 +1231,10 @@ jit_event_handler (gdbarch *gdbarch, objfile *jiter) { objfile *jited = jit_find_objf_with_entry_addr (entry_addr); if (jited == nullptr) - printf_unfiltered (_("Unable to find JITed code " - "entry at address: %s\n"), - paddress (gdbarch, entry_addr)); + fprintf_unfiltered (gdb_stderr, + _("Unable to find JITed code " + "entry at address: %s\n"), + paddress (gdbarch, entry_addr)); else jited->unlink (); -- 2.30.2