From 10010058f222196d4dbc3866f33fbaf0bb5de3e2 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Wed, 15 Feb 2012 18:09:20 +0000 Subject: [PATCH] 2012-02-15 Pedro Alves * gdb.trace/backtrace.exp: Issue UNSUPPORTED instead of PASS when the target doesn't support tracepoints. * gdb.trace/circ.exp: Ditto. * gdb.trace/collection.exp: Ditto. * gdb.trace/packetlen.exp: Ditto. * gdb.trace/passc-dyn.exp: Ditto. * gdb.trace/report.exp: Ditto. * gdb.trace/tfind.exp: Ditto. * gdb.trace/tspeed.exp: Ditto. * gdb.trace/tsv.exp: Ditto. * gdb.trace/unavailable.exp: Ditto. * gdb.trace/while-dyn.exp: Ditto. --- gdb/testsuite/ChangeLog | 15 +++++++++++++++ gdb/testsuite/gdb.trace/backtrace.exp | 4 +--- gdb/testsuite/gdb.trace/circ.exp | 5 +---- gdb/testsuite/gdb.trace/collection.exp | 4 +--- gdb/testsuite/gdb.trace/packetlen.exp | 4 +--- gdb/testsuite/gdb.trace/passc-dyn.exp | 4 +--- gdb/testsuite/gdb.trace/report.exp | 4 +--- gdb/testsuite/gdb.trace/tfind.exp | 4 +--- gdb/testsuite/gdb.trace/tspeed.exp | 4 +--- gdb/testsuite/gdb.trace/tsv.exp | 2 +- gdb/testsuite/gdb.trace/unavailable.exp | 4 +--- gdb/testsuite/gdb.trace/while-dyn.exp | 4 +--- 12 files changed, 26 insertions(+), 32 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 449b80e778b..bd967dcf13b 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,18 @@ +2012-02-15 Pedro Alves + + * gdb.trace/backtrace.exp: Issue UNSUPPORTED instead of PASS when + the target doesn't support tracepoints. + * gdb.trace/circ.exp: Ditto. + * gdb.trace/collection.exp: Ditto. + * gdb.trace/packetlen.exp: Ditto. + * gdb.trace/passc-dyn.exp: Ditto. + * gdb.trace/report.exp: Ditto. + * gdb.trace/tfind.exp: Ditto. + * gdb.trace/tspeed.exp: Ditto. + * gdb.trace/tsv.exp: Ditto. + * gdb.trace/unavailable.exp: Ditto. + * gdb.trace/while-dyn.exp: Ditto. + 2012-02-15 Pedro Alves * gdb.trace/circ.exp (trace_buffer_normal): Rewrite using diff --git a/gdb/testsuite/gdb.trace/backtrace.exp b/gdb/testsuite/gdb.trace/backtrace.exp index f68344283ca..7d978930bbe 100644 --- a/gdb/testsuite/gdb.trace/backtrace.exp +++ b/gdb/testsuite/gdb.trace/backtrace.exp @@ -35,10 +35,8 @@ gdb_test "tfind none" ".*" "" runto_main gdb_reinitialize_dir $srcdir/$subdir -# We generously give ourselves one "pass" if we successfully -# detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/circ.exp b/gdb/testsuite/gdb.trace/circ.exp index 4344bebc086..67b4389c6a8 100644 --- a/gdb/testsuite/gdb.trace/circ.exp +++ b/gdb/testsuite/gdb.trace/circ.exp @@ -125,11 +125,8 @@ proc trace_buffer_normal { } { # return 0 for success, 1 for failure proc gdb_trace_circular_tests { } { - - # We generously give ourselves one "pass" if we successfully - # detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/collection.exp b/gdb/testsuite/gdb.trace/collection.exp index 9398248cc2b..9beb9afba2c 100644 --- a/gdb/testsuite/gdb.trace/collection.exp +++ b/gdb/testsuite/gdb.trace/collection.exp @@ -779,10 +779,8 @@ proc gdb_trace_collection_test {} { clean_restart $executable runto_main -# We generously give ourselves one "pass" if we successfully -# detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/packetlen.exp b/gdb/testsuite/gdb.trace/packetlen.exp index ccc43841b99..4ce13e660f0 100644 --- a/gdb/testsuite/gdb.trace/packetlen.exp +++ b/gdb/testsuite/gdb.trace/packetlen.exp @@ -35,10 +35,8 @@ gdb_test "tfind none" ".*" "" runto_main gdb_reinitialize_dir $srcdir/$subdir -# We generously give ourselves one "pass" if we successfully -# detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/passc-dyn.exp b/gdb/testsuite/gdb.trace/passc-dyn.exp index 1ec120e11f9..718a4da6bb0 100644 --- a/gdb/testsuite/gdb.trace/passc-dyn.exp +++ b/gdb/testsuite/gdb.trace/passc-dyn.exp @@ -34,10 +34,8 @@ gdb_test "tfind none" ".*" "" runto_main gdb_reinitialize_dir $srcdir/$subdir -# We generously give ourselves one "pass" if we successfully -# detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/report.exp b/gdb/testsuite/gdb.trace/report.exp index 2f2962a3a05..7c08a419b84 100644 --- a/gdb/testsuite/gdb.trace/report.exp +++ b/gdb/testsuite/gdb.trace/report.exp @@ -35,10 +35,8 @@ gdb_test "tfind none" ".*" "" runto_main gdb_reinitialize_dir $srcdir/$subdir -# We generously give ourselves one "pass" if we successfully -# detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/tfind.exp b/gdb/testsuite/gdb.trace/tfind.exp index ec0ba11e697..d025f39cba5 100644 --- a/gdb/testsuite/gdb.trace/tfind.exp +++ b/gdb/testsuite/gdb.trace/tfind.exp @@ -36,10 +36,8 @@ gdb_test "tfind none" ".*" "" runto_main gdb_reinitialize_dir $srcdir/$subdir -# We generously give ourselves one "pass" if we successfully -# detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/tspeed.exp b/gdb/testsuite/gdb.trace/tspeed.exp index 0becf18859a..b6e6ecad57b 100644 --- a/gdb/testsuite/gdb.trace/tspeed.exp +++ b/gdb/testsuite/gdb.trace/tspeed.exp @@ -129,10 +129,8 @@ proc gdb_trace_collection_test {} { clean_restart $executable runto_main -# We generously give ourselves one "pass" if we successfully -# detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/tsv.exp b/gdb/testsuite/gdb.trace/tsv.exp index 373bc420d0f..b8af4d63b6a 100644 --- a/gdb/testsuite/gdb.trace/tsv.exp +++ b/gdb/testsuite/gdb.trace/tsv.exp @@ -92,7 +92,7 @@ gdb_reinitialize_dir $srcdir/$subdir # The rest of the testing needs actual tracing to work. if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/unavailable.exp b/gdb/testsuite/gdb.trace/unavailable.exp index 5d82d4c8649..87af8601f0e 100644 --- a/gdb/testsuite/gdb.trace/unavailable.exp +++ b/gdb/testsuite/gdb.trace/unavailable.exp @@ -586,10 +586,8 @@ proc gdb_trace_collection_test {} { clean_restart $executable runto_main -# We generously give ourselves one "pass" if we successfully -# detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } diff --git a/gdb/testsuite/gdb.trace/while-dyn.exp b/gdb/testsuite/gdb.trace/while-dyn.exp index f71f3a417e8..3e8aa2da86d 100644 --- a/gdb/testsuite/gdb.trace/while-dyn.exp +++ b/gdb/testsuite/gdb.trace/while-dyn.exp @@ -36,10 +36,8 @@ gdb_test "tfind none" ".*" "" runto_main gdb_reinitialize_dir $srcdir/$subdir -# We generously give ourselves one "pass" if we successfully -# detect that this test cannot be run on this target! if { ![gdb_target_supports_trace] } then { - pass "Current target does not support trace" + unsupported "Current target does not support trace" return 1; } -- 2.30.2