From 10125099f09197b325c7e0e7f2af6d3c04f929a6 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 21 Dec 2015 14:38:51 -0500 Subject: [PATCH] Remove dead code in testsuite This patch removes cases from the testsuite that are not posssibly used. The messages "Catch of * not yet implemented" were removed here: https://www.sourceware.org/ml/gdb-patches/2004-01/msg00679.html I changed the regexp at the same time to match the string more closely. gdb/testsuite/ChangeLog: * gdb.base/break.exp: Remove dead code. * gdb.base/sepdebug.exp: Likewise. --- gdb/testsuite/ChangeLog | 5 ++++ gdb/testsuite/gdb.base/break.exp | 35 +++++---------------------- gdb/testsuite/gdb.base/sepdebug.exp | 37 +++++------------------------ 3 files changed, 17 insertions(+), 60 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index b1f19d92376..5ea5cf569cb 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-12-21 Simon Marchi + + * gdb.base/break.exp: Remove dead code. + * gdb.base/sepdebug.exp: Likewise. + 2015-12-21 Simon Marchi * gdb.asm/asm-source.exp: Remove HP-UX references. diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp index 6ca910c6705..63fc42b7c8d 100644 --- a/gdb/testsuite/gdb.base/break.exp +++ b/gdb/testsuite/gdb.base/break.exp @@ -473,37 +473,14 @@ gdb_test "catch" \ "Catch requires an event name." \ "catch requires an event name" +gdb_test "catch fork" "Catchpoint \[0-9\]+ \\(fork\\)" \ + "set catch fork, never expected to trigger" -set name "set catch fork, never expected to trigger" -gdb_test_multiple "catch fork" "$name" { - -re "Catchpoint \[0-9\]* .fork..*$gdb_prompt $" { - pass $name - } - -re "Catch of fork not yet implemented.*$gdb_prompt $" { - pass $name - } -} +gdb_test "catch vfork" "Catchpoint \[0-9\]+ \\(vfork\\)" \ + "set catch vfork, never expected to trigger" - -set name "set catch vfork, never expected to trigger" -gdb_test_multiple "catch vfork" "$name" { - -re "Catchpoint \[0-9\]* .vfork..*$gdb_prompt $" { - pass $name - } - -re "Catch of vfork not yet implemented.*$gdb_prompt $" { - pass $name - } -} - -set name "set catch exec, never expected to trigger" -gdb_test_multiple "catch exec" "$name" { - -re "Catchpoint \[0-9\]* .exec..*$gdb_prompt $" { - pass $name - } - -re "Catch of exec not yet implemented.*$gdb_prompt $" { - pass $name - } -} +gdb_test "catch exec" "Catchpoint \[0-9\]+ \\(exec\\)" \ + "set catch exec, never expected to trigger" # Verify that GDB responds gracefully when asked to set a breakpoint # on a nonexistent source line. diff --git a/gdb/testsuite/gdb.base/sepdebug.exp b/gdb/testsuite/gdb.base/sepdebug.exp index 29b4c8c8e09..f7de5a459ca 100644 --- a/gdb/testsuite/gdb.base/sepdebug.exp +++ b/gdb/testsuite/gdb.base/sepdebug.exp @@ -283,39 +283,14 @@ if ![runto_main] then { fail "sepdebug tests suppressed" } gdb_test "catch" "Catch requires an event name.*" \ "catch requires an event name" -set name "set catch fork, never expected to trigger" -gdb_test_multiple "catch fork" $name { - -re "Catchpoint \[0-9\]* .fork.*$gdb_prompt $" { - pass $name - } - -re "Catch of fork not yet implemented.*$gdb_prompt $" { - pass $name - } -} +gdb_test "catch fork" "Catchpoint \[0-9\]+ \\(fork\\)" \ + "set catch fork, never expected to trigger" -# If we are on HP-UX 10.20, we expect an error message to be -# printed if we type "catch vfork" at the gdb gdb_prompt. This is -# because on HP-UX 10.20, we cannot catch vfork events. - -set name "set catch vfork, never expected to trigger" -gdb_test_multiple "catch vfork" $name { - -re "Catchpoint \[0-9\]* .vfork.*$gdb_prompt $" { - pass $name - } - -re "Catch of vfork not yet implemented.*$gdb_prompt $" { - pass $name - } -} +gdb_test "catch vfork" "Catchpoint \[0-9\]+ \\(vfork\\)" \ + "set catch vfork, never expected to trigger" -set name "set catch exec, never expected to trigger" -gdb_test_multiple "catch exec" $name { - -re "Catchpoint \[0-9\]* .exec.*$gdb_prompt $" { - pass $name - } - -re "Catch of exec not yet implemented.*$gdb_prompt $" { - pass $name - } -} +gdb_test "catch exec" "Catchpoint \[0-9\]+ \\(exec\\)" \ + "set catch exec, never expected to trigger" # Verify that GDB responds gracefully when asked to set a breakpoint # on a nonexistent source line. -- 2.30.2