From 10574a9f5cb4c431cba1af66d95000960ae97bfc Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Fri, 16 Dec 2011 17:34:49 -0500 Subject: [PATCH] re PR c++/51461 ([c++0x] [4.7 Regression] ICE with invalid initialization of static data member) PR c++/51461 * decl.c (check_static_variable_definition): Check COMPLETE_TYPE_P before literal_type_p. From-SVN: r182415 --- gcc/cp/ChangeLog | 4 ++++ gcc/cp/decl.c | 7 +++++-- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/init/static4.C | 6 ++++++ 4 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.dg/init/static4.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index ea5ebaa8a8a..9773ae7e2ac 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,5 +1,9 @@ 2011-12-16 Jason Merrill + PR c++/51461 + * decl.c (check_static_variable_definition): Check COMPLETE_TYPE_P + before literal_type_p. + PR c++/51331 * class.c (convert_to_base_statically): Just call build_simple_base_path. diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index 919e2355d88..fedc52cd833 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -5449,7 +5449,7 @@ check_initializer (tree decl, tree init, int flags, VEC(tree,gc) **cleanups) } else if (!COMPLETE_TYPE_P (type)) { - error ("%qD has incomplete type", decl); + error ("%q#D has incomplete type", decl); TREE_TYPE (decl) = error_mark_node; return NULL_TREE; } @@ -7807,7 +7807,10 @@ check_static_variable_definition (tree decl, tree type) return 0; else if (cxx_dialect >= cxx0x && !INTEGRAL_OR_ENUMERATION_TYPE_P (type)) { - if (literal_type_p (type)) + if (!COMPLETE_TYPE_P (type)) + error ("in-class initialization of static data member %q#D of " + "incomplete type", decl); + else if (literal_type_p (type)) permerror (input_location, "% needed for in-class initialization of " "static data member %q#D of non-integral type", decl); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 0cc64645881..37023d12bd5 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-12-16 Jason Merrill + + PR c++/51461 + * g++.dg/init/static4.C: New. + 2011-12-16 Jason Merrill PR c++/51331 diff --git a/gcc/testsuite/g++.dg/init/static4.C b/gcc/testsuite/g++.dg/init/static4.C new file mode 100644 index 00000000000..0cdc48b0e45 --- /dev/null +++ b/gcc/testsuite/g++.dg/init/static4.C @@ -0,0 +1,6 @@ +// PR c++/51461 + +struct A +{ + static const A a = 0; // { dg-error "incomplete|non-integral" } +}; -- 2.30.2