From 11d688d9f0d2ee4d0178d1807c0075e5e8364b1d Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Mon, 23 Oct 2017 10:34:54 +1000 Subject: [PATCH] mesa/bufferobj: don't double negate the range MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This fixes a regression I introduced refactoring this code, I managed to invert range twice, I moved the inversion into the common code, but forgot to stop doing it in the callee. Fixes: GL45-CTS.multi_bind.dispatch_bind_buffers_base Fixes: 35ac13ed3 (mesa/bufferobj: consolidate some codepaths between ubo/ssbo/atomics.) Reported-by: Nicolai Hähnle Reviewed-by: Samuel Pitoiset Signed-off-by: Dave Airlie --- src/mesa/main/bufferobj.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index b7a969265ac..dfeea94bd19 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -3815,7 +3815,7 @@ bind_uniform_buffers(struct gl_context *ctx, GLuint first, GLsizei count, } set_buffer_multi_binding(ctx, buffers, i, caller, - binding, offset, size, !range, + binding, offset, size, range, USAGE_UNIFORM_BUFFER); } @@ -3916,7 +3916,7 @@ bind_shader_storage_buffers(struct gl_context *ctx, GLuint first, } set_buffer_multi_binding(ctx, buffers, i, caller, - binding, offset, size, !range, + binding, offset, size, range, USAGE_SHADER_STORAGE_BUFFER); } @@ -4238,7 +4238,7 @@ bind_atomic_buffers(struct gl_context *ctx, } set_buffer_multi_binding(ctx, buffers, i, caller, - binding, offset, size, !range, + binding, offset, size, range, USAGE_ATOMIC_COUNTER_BUFFER); } -- 2.30.2