From 11e49871352cdb5d0fa5338a0be4995f7393b06f Mon Sep 17 00:00:00 2001 From: Axel Davy Date: Mon, 7 Mar 2016 22:26:22 +0100 Subject: [PATCH] radeonsi: Mixed colorbuffer formats are unsupported MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Besides depth/stencil, the hardware doesn't support mixed formats. The GL state tracker doesn't make use of them. Signed-off-by: Axel Davy Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 85d8509f1c8..aefa336c50f 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++ b/src/gallium/drivers/radeonsi/si_state.c @@ -1145,6 +1145,11 @@ static uint32_t si_translate_colorformat(enum pipe_format format) if (desc->layout != UTIL_FORMAT_LAYOUT_PLAIN) return V_028C70_COLOR_INVALID; + /* hw cannot support mixed formats (except depth/stencil, since + * stencil is not written to). */ + if (desc->is_mixed && desc->colorspace != UTIL_FORMAT_COLORSPACE_ZS) + return V_028C70_COLOR_INVALID; + switch (desc->nr_channels) { case 1: switch (desc->channel[0].size) { @@ -1423,6 +1428,11 @@ static uint32_t si_translate_texformat(struct pipe_screen *screen, /* R8G8Bx_SNORM - TODO CxV8U8 */ + /* hw cannot support mixed formats (except depth/stencil, since only + * depth is read).*/ + if (desc->is_mixed && desc->colorspace != UTIL_FORMAT_COLORSPACE_ZS) + goto out_unknown; + /* See whether the components are of the same size. */ for (i = 1; i < desc->nr_channels; i++) { uniform = uniform && desc->channel[0].size == desc->channel[i].size; -- 2.30.2