From 1297a2f020b41485135f3e58100d689799785ee5 Mon Sep 17 00:00:00 2001 From: Michael Snyder Date: Fri, 10 Aug 2001 21:52:17 +0000 Subject: [PATCH] 2001-08-10 Michael Snyder * regcache.c (legacy_write_register_gen): Don't 'optimize out' a write_register to a pseudo-reg. Target_store_pseudo_register needs to get called, because these regs may be computed and may have side-effects. --- gdb/ChangeLog | 7 +++++++ gdb/regcache.c | 17 +++++++++-------- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 74cad451283..25d32330c96 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2001-08-10 Michael Snyder + + * regcache.c (legacy_write_register_gen): Don't 'optimize out' + a write_register to a pseudo-reg. Target_store_pseudo_register + needs to get called, because these regs may be computed and may + have side-effects. + 2001-08-10 Keith Seitz * gdb-events.sh: Deal with event notifications with no diff --git a/gdb/regcache.c b/gdb/regcache.c index b939d9a8fb1..ffd13bf8a4b 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -334,15 +334,16 @@ legacy_write_register_gen (int regnum, char *myaddr) size = REGISTER_RAW_SIZE (regnum); - /* If we have a valid copy of the register, and new value == old value, - then don't bother doing the actual store. */ - - if (register_cached (regnum) - && memcmp (register_buffer (regnum), myaddr, size) == 0) - return; - if (real_register (regnum)) - target_prepare_to_store (); + { + /* If we have a valid copy of the register, and new value == old + value, then don't bother doing the actual store. */ + if (register_cached (regnum) + && memcmp (register_buffer (regnum), myaddr, size) == 0) + return; + else + target_prepare_to_store (); + } memcpy (register_buffer (regnum), myaddr, size); -- 2.30.2