From 129f3276989de6f07ba02eb3fe175f731f2ae9a8 Mon Sep 17 00:00:00 2001 From: Romain Naour Date: Fri, 19 Jan 2018 11:15:03 +0100 Subject: [PATCH] package/dash: add /etc/dash to /etc/shells When dash is selected, /bin/dash is not added to /etc/shells (see man shells). So, login tools like dropbear reject the ssh connections for users using dash as shell in /etc/passwd. buildroot authpriv.warn dropbear[853]: User 'kubu' has invalid shell, rejected Signed-off-by: Romain Naour Reviewed-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni --- package/dash/dash.mk | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/package/dash/dash.mk b/package/dash/dash.mk index 2ee292b8d3..9a26ebb642 100644 --- a/package/dash/dash.mk +++ b/package/dash/dash.mk @@ -28,4 +28,12 @@ define DASH_INSTALL_TARGET_CMDS $(INSTALL) -m 0755 $(@D)/src/dash $(TARGET_DIR)/bin/dash endef +# Add /bin/dash to /etc/shells otherwise some login tools like dropbear +# can reject the user connection. See man shells. +define DASH_ADD_DASH_TO_SHELLS + grep -qsE '^/bin/dash$$' $(TARGET_DIR)/etc/shells \ + || echo "/bin/dash" >> $(TARGET_DIR)/etc/shells +endef +DASH_TARGET_FINALIZE_HOOKS += DASH_ADD_DASH_TO_SHELLS + $(eval $(autotools-package)) -- 2.30.2