From 12c574caf6f0766266813fef7be8a2367a9d0700 Mon Sep 17 00:00:00 2001 From: Paolo Carlini Date: Mon, 5 Dec 2011 15:46:30 +0000 Subject: [PATCH] re PR c++/51404 ([c++0x] [4.7 Regression] ICE with invalid use of auto) /cp 2011-12-05 Paolo Carlini PR c++/51404 * typeck2.c (build_functional_cast): Early return error_mark_node for invalid uses of 'auto'. * parser.c (cp_parser_direct_declarator): When cp_parser_constant_expression returns error do not produce further diagnostic for the bound. /testsuite 2011-12-05 Paolo Carlini PR c++/51404 * g++.dg/cpp0x/auto28.C: New. From-SVN: r182011 --- gcc/cp/ChangeLog | 9 +++++++++ gcc/cp/parser.c | 12 +++++++----- gcc/cp/typeck2.c | 2 +- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/cpp0x/auto28.C | 4 ++++ 5 files changed, 26 insertions(+), 6 deletions(-) create mode 100644 gcc/testsuite/g++.dg/cpp0x/auto28.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 8f26f239ffd..fcd44f072de 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,12 @@ +2011-12-05 Paolo Carlini + + PR c++/51404 + * typeck2.c (build_functional_cast): Early return error_mark_node + for invalid uses of 'auto'. + * parser.c (cp_parser_direct_declarator): When + cp_parser_constant_expression returns error do not produce further + diagnostic for the bound. + 2011-12-03 Paolo Carlini PR c++/51313 diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index 2fdd6753d08..69f1eabb940 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/parser.c @@ -16055,18 +16055,20 @@ cp_parser_direct_declarator (cp_parser* parser, &non_constant_p); if (!non_constant_p) /* OK */; - /* Normally, the array bound must be an integral constant - expression. However, as an extension, we allow VLAs - in function scopes as long as they aren't part of a - parameter declaration. */ + else if (error_operand_p (bounds)) + /* Already gave an error. */; else if (!parser->in_function_body || current_binding_level->kind == sk_function_parms) { + /* Normally, the array bound must be an integral constant + expression. However, as an extension, we allow VLAs + in function scopes as long as they aren't part of a + parameter declaration. */ cp_parser_error (parser, "array bound is not an integer constant"); bounds = error_mark_node; } - else if (processing_template_decl && !error_operand_p (bounds)) + else if (processing_template_decl) { /* Remember this wasn't a constant-expression. */ bounds = build_nop (TREE_TYPE (bounds), bounds); diff --git a/gcc/cp/typeck2.c b/gcc/cp/typeck2.c index 70edc2f5a4d..2db3248d028 100644 --- a/gcc/cp/typeck2.c +++ b/gcc/cp/typeck2.c @@ -1653,7 +1653,7 @@ build_functional_cast (tree exp, tree parms, tsubst_flags_t complain) { if (complain & tf_error) error ("invalid use of %"); - type = error_mark_node; + return error_mark_node; } if (processing_template_decl) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 20917403709..31aa738768d 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-12-05 Paolo Carlini + + PR c++/51404 + * g++.dg/cpp0x/auto28.C: New. + 2011-12-05 Matthew Gretton-Dann * gcc.dg/torture/vec-cvt-1.c (FLTTEST): Call rand instead of random. diff --git a/gcc/testsuite/g++.dg/cpp0x/auto28.C b/gcc/testsuite/g++.dg/cpp0x/auto28.C new file mode 100644 index 00000000000..8d250166a8c --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/auto28.C @@ -0,0 +1,4 @@ +// PR c++/51404 +// { dg-options -std=c++0x } + +int i = auto().x; // { dg-error "invalid use of" } -- 2.30.2