From 130b12f96a4e60c88e8ccd5e673413e0a8c0c127 Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Fri, 11 Nov 2016 16:45:00 +0000 Subject: [PATCH] egl/wayland: remove non-applicable destroyDrawable from error path If we fail to create the drawable there's not much point in attampting to destroy it. Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 4fd4289679e..395f1e181d3 100644 --- a/src/egl/drivers/dri2/platform_wayland.c +++ b/src/egl/drivers/dri2/platform_wayland.c @@ -1752,7 +1752,7 @@ dri2_wl_swrast_create_window_surface(_EGLDriver *drv, _EGLDisplay *disp, config, dri2_surf); if (dri2_surf->dri_drawable == NULL) { _eglError(EGL_BAD_ALLOC, "swrast->createNewDrawable"); - goto cleanup_dri_drawable; + goto cleanup_surf; } dri2_wl_swap_interval(drv, disp, &dri2_surf->base, @@ -1760,8 +1760,6 @@ dri2_wl_swrast_create_window_surface(_EGLDriver *drv, _EGLDisplay *disp, return &dri2_surf->base; - cleanup_dri_drawable: - dri2_dpy->core->destroyDrawable(dri2_surf->dri_drawable); cleanup_surf: free(dri2_surf); -- 2.30.2