From 13cda5a73442565abb3222d3197faa790ce7e016 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Fri, 12 Feb 2021 16:56:55 -0800 Subject: [PATCH] arch: Stop including unnecessary FP headers. Nothing is used from them. They're probably there as copy/paste from other ISAs, or old code that's been replaced. This also gets rid of some #if guarded includes which is a nice cleanup. Change-Id: Icd84300fb7531ec203ce4acbdae1d311e56cc873 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/41353 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power Tested-by: kokoro --- src/arch/mips/isa/includes.isa | 10 ++-------- src/arch/power/isa/includes.isa | 6 ------ src/arch/x86/isa/includes.isa | 25 +++++++------------------ 3 files changed, 9 insertions(+), 32 deletions(-) diff --git a/src/arch/mips/isa/includes.isa b/src/arch/mips/isa/includes.isa index 34922e4cf..d17bcf6e2 100644 --- a/src/arch/mips/isa/includes.isa +++ b/src/arch/mips/isa/includes.isa @@ -41,6 +41,7 @@ output header {{ #include "arch/mips/pra_constants.hh" #include "cpu/static_inst.hh" #include "mem/packet.hh" + }}; output decoder {{ @@ -56,14 +57,11 @@ output decoder {{ #include "arch/mips/pra_constants.hh" #include "arch/mips/tlb.hh" #include "arch/mips/utility.hh" -#include "base/loader/symtab.hh" #include "base/cprintf.hh" +#include "base/loader/symtab.hh" #include "cpu/thread_context.hh" #include "mem/packet.hh" #include "sim/full_system.hh" -#if defined(linux) -#include -#endif using namespace MipsISA; }}; @@ -83,10 +81,6 @@ output exec {{ #include "arch/mips/pra_constants.hh" #include "arch/mips/tlb.hh" #include "arch/mips/utility.hh" -#if defined(linux) -#include -#endif - #include "base/condcodes.hh" #include "cpu/base.hh" #include "cpu/exetrace.hh" diff --git a/src/arch/power/isa/includes.isa b/src/arch/power/isa/includes.isa index ac7756cca..c97aba97d 100644 --- a/src/arch/power/isa/includes.isa +++ b/src/arch/power/isa/includes.isa @@ -52,9 +52,6 @@ using namespace PowerISA; output decoder {{ #include -#if defined(linux) -#include -#endif #include "arch/power/decoder.hh" #include "arch/power/faults.hh" @@ -69,9 +66,6 @@ using namespace PowerISA; output exec {{ #include -#if defined(linux) -#include -#endif #include "arch/generic/memhelpers.hh" #include "arch/power/faults.hh" diff --git a/src/arch/x86/isa/includes.isa b/src/arch/x86/isa/includes.isa index 3bd7872b8..27ef9886f 100644 --- a/src/arch/x86/isa/includes.isa +++ b/src/arch/x86/isa/includes.isa @@ -53,13 +53,13 @@ output header {{ #include #include "arch/generic/debugfaults.hh" +#include "arch/x86/emulenv.hh" #include "arch/x86/insts/macroop.hh" #include "arch/x86/insts/microfpop.hh" #include "arch/x86/insts/microldstop.hh" #include "arch/x86/insts/micromediaop.hh" #include "arch/x86/insts/microregop.hh" #include "arch/x86/insts/static_inst.hh" -#include "arch/x86/emulenv.hh" #include "arch/x86/isa_traits.hh" #include "arch/x86/registers.hh" #include "arch/x86/types.hh" @@ -73,46 +73,35 @@ using X86ISA::InstRegIndex; }}; output decoder {{ +#include + #include "arch/x86/decoder.hh" +#include "arch/x86/faults.hh" +#include "arch/x86/microcode_rom.hh" #include "arch/x86/regs/float.hh" #include "arch/x86/regs/misc.hh" #include "arch/x86/regs/segment.hh" -#include "arch/x86/faults.hh" -#include "arch/x86/microcode_rom.hh" #include "arch/x86/tlb.hh" -#include "base/loader/symtab.hh" #include "base/cprintf.hh" +#include "base/loader/symtab.hh" #include "base/logging.hh" #include "cpu/thread_context.hh" // for Jump::branchTarget() #include "mem/packet.hh" #include "sim/full_system.hh" -#if defined(linux) || defined(__APPLE__) -#include -#endif -#include - using namespace X86ISA; }}; output exec {{ -#if defined(linux) || defined(__APPLE__) -#include -#endif - -#if defined(__sun) || defined (__OpenBSD__) -#include -#endif - #include #include #include "arch/generic/debugfaults.hh" -#include "arch/x86/regs/misc.hh" #include "arch/x86/cpuid.hh" #include "arch/x86/faults.hh" #include "arch/x86/memhelpers.hh" #include "arch/x86/pseudo_inst_abi.hh" +#include "arch/x86/regs/misc.hh" #include "arch/x86/tlb.hh" #include "base/compiler.hh" #include "base/condcodes.hh" -- 2.30.2