From 1428d9e013ba47c9257d2fc33378b6bb45308b87 Mon Sep 17 00:00:00 2001 From: Jan Hubicka Date: Sat, 28 May 2016 18:20:06 +0200 Subject: [PATCH] profile.c (compute_branch_probabilities): Do not report hitrates here. * profile.c (compute_branch_probabilities): Do not report hitrates here. (branch_prob): Report hitrates here. * predict.c (gimple_predict_edge): Do not assert profile status; fix formatting issues. From-SVN: r236849 --- gcc/ChangeLog | 8 ++++++++ gcc/predict.c | 8 ++++---- gcc/profile.c | 4 ++-- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 3a75b8034e2..385674508df 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2016-05-27 Jan Hubicka + + * profile.c (compute_branch_probabilities): Do not report hitrates + here. + (branch_prob): Report hitrates here. + * predict.c (gimple_predict_edge): Do not assert profile status; + fix formatting issues. + 2016-05-27 Jan Hubicka * predict.c (edge_predicted_by_p): New function. diff --git a/gcc/predict.c b/gcc/predict.c index 22ec8a053a0..3743b0107a6 100644 --- a/gcc/predict.c +++ b/gcc/predict.c @@ -593,10 +593,10 @@ rtl_predict_edge (edge e, enum br_predictor predictor, int probability) void gimple_predict_edge (edge e, enum br_predictor predictor, int probability) { - gcc_assert (profile_status_for_fn (cfun) != PROFILE_GUESSED); - if ((e->src != ENTRY_BLOCK_PTR_FOR_FN (cfun) && EDGE_COUNT (e->src->succs) > - 1) - && flag_guess_branch_prob && optimize) + if (e->src != ENTRY_BLOCK_PTR_FOR_FN (cfun) + && EDGE_COUNT (e->src->succs) > 1 + && flag_guess_branch_prob + && optimize) { struct edge_prediction *i = XNEW (struct edge_prediction); edge_prediction *&preds = bb_predictions->get_or_insert (e->src); diff --git a/gcc/profile.c b/gcc/profile.c index 39c81d4fbaf..007379baa13 100644 --- a/gcc/profile.c +++ b/gcc/profile.c @@ -845,8 +845,6 @@ compute_branch_probabilities (unsigned cfg_checksum, unsigned lineno_checksum) fputc ('\n', dump_file); fputc ('\n', dump_file); } - if (dump_file && (dump_flags & TDF_DETAILS)) - report_predictor_hitrates (); free_aux_for_blocks (); } @@ -1331,6 +1329,8 @@ branch_prob (void) values.release (); free_edge_list (el); coverage_end_function (lineno_checksum, cfg_checksum); + if (dump_file && (dump_flags & TDF_DETAILS)) + report_predictor_hitrates (); } /* Union find algorithm implementation for the basic blocks using -- 2.30.2