From 143176163d39720fa040b441be6290286590e5cf Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Fri, 9 Nov 2018 14:13:35 -0800 Subject: [PATCH] intel/eu/gen12: Add sanity-check asserts to brw_inst_bits() and brw_inst_set_bits(). These caught a few bugs during the development of this series. Reviewed-by: Caio Marcelo de Oliveira Filho Reviewed-by: Jordan Justen Reviewed-by: Kenneth Graunke --- src/intel/compiler/brw_inst.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_inst.h b/src/intel/compiler/brw_inst.h index 624cbe020ca..5a1e5cfba72 100644 --- a/src/intel/compiler/brw_inst.h +++ b/src/intel/compiler/brw_inst.h @@ -1161,6 +1161,7 @@ BRW_IA16_ADDR_IMM(send_dst, -1, -1, 62, 56, 52) static inline uint64_t brw_inst_bits(const brw_inst *inst, unsigned high, unsigned low) { + assert(high >= low); /* We assume the field doesn't cross 64-bit boundaries. */ const unsigned word = high / 64; assert(word == low / 64); @@ -1181,6 +1182,7 @@ brw_inst_bits(const brw_inst *inst, unsigned high, unsigned low) static inline void brw_inst_set_bits(brw_inst *inst, unsigned high, unsigned low, uint64_t value) { + assert(high >= low); const unsigned word = high / 64; assert(word == low / 64); -- 2.30.2